Re: [PR] Add a Faiss codec for KNN searches [lucene]

kaivalnp commented on PR #14178: URL: https://github.com/apache/lucene/pull/14178#issuecomment-2954666179 Thank you for the review @mikemccand, super helpful ! I've tried to incorporate all changes, and made some other fixes / refactors as well ! As a follow up, could you allow the

Re: [PR] Add a Faiss codec for KNN searches [lucene]

kaivalnp commented on code in PR #14178: URL: https://github.com/apache/lucene/pull/14178#discussion_r2135040134 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/codecs/faiss/LibFaissC.java: ## @@ -0,0 +1,493 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add a Faiss codec for KNN searches [lucene]

kaivalnp commented on PR #14178: URL: https://github.com/apache/lucene/pull/14178#issuecomment-2954723052 I also re-ran a performance test since it's been a long time: Lucene: ``` recall latency (ms)nDoc topK fanout maxConn beamWidth quantized visited index s index

Re: [PR] IndexOrDocValuesQuery and IndexSortSortedNumericDocValuesRangeQuery should only be counted once when computing maxClauseCount [lucene]

iverase commented on PR #14759: URL: https://github.com/apache/lucene/pull/14759#issuecomment-2954789191 @romseygeek sorry for the direct ping but as you were involved in the original development of the query visitor API, do you have any opinions here? what is a leave in the query tree? -