Re: [PR] Fix documentation regarding benchmark running [lucene]

2025-05-29 Thread via GitHub
jainankitk commented on PR #14667: URL: https://github.com/apache/lucene/pull/14667#issuecomment-2920814107 > @jainankitk Do you really want changelogs for this kind of changes? Nevertheless, I added it. I don't have strong opinion either way, but generally doesn't hurt to have the c

Re: [PR] Add a DoubleValuesSource for scoring full precision vector similarity [lucene]

2025-05-29 Thread via GitHub
dungba88 commented on code in PR #14708: URL: https://github.com/apache/lucene/pull/14708#discussion_r2115104082 ## lucene/core/src/java/org/apache/lucene/search/ByteVectorSimilarityValuesSource.java: ## @@ -42,7 +78,35 @@ public VectorScorer getScorer(LeafReaderContext ctx) thr

Re: [PR] [BlockJoin] Add ParentsChildrenBlockJoinQuery to support parent and c… [lucene]

2025-05-29 Thread via GitHub
github-actions[bot] commented on PR #14728: URL: https://github.com/apache/lucene/pull/14728#issuecomment-2920886268 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

[PR] Fix java doc in IndexWriter. [lucene]

2025-05-29 Thread via GitHub
vsop-479 opened a new pull request, #14733: URL: https://github.com/apache/lucene/pull/14733 ### Description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Fix java doc in IndexWriter. [lucene]

2025-05-29 Thread via GitHub
github-actions[bot] commented on PR #14733: URL: https://github.com/apache/lucene/pull/14733#issuecomment-2921103873 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

Re: [PR] Fix java doc in IndexWriter. [lucene]

2025-05-29 Thread via GitHub
vsop-479 commented on PR #14733: URL: https://github.com/apache/lucene/pull/14733#issuecomment-2921123987 In IndexWriter , `` (flush, sequence_number, mergePolicy) just linked to `public class IndexWriter`. I am not sure whether it is a right place. -- This is an automated message from

Re: [PR] Add a DoubleValuesSource for scoring full precision vector similarity [lucene]

2025-05-29 Thread via GitHub
dungba88 commented on code in PR #14708: URL: https://github.com/apache/lucene/pull/14708#discussion_r2115082489 ## lucene/core/src/java/org/apache/lucene/search/ByteVectorSimilarityValuesSource.java: ## @@ -42,7 +78,35 @@ public VectorScorer getScorer(LeafReaderContext ctx) thr

Re: [I] A little optimization about BKDReader [lucene]

2025-05-29 Thread via GitHub
jainankitk commented on issue #14717: URL: https://github.com/apache/lucene/issues/14717#issuecomment-2920833593 While I can see the concerns with high dimensional data, I am wondering if this can be a good improvement for [PointTreeBulkCollector](https://github.com/apache/lucene/blob/main/

Re: [PR] Fix documentation regarding benchmark running [lucene]

2025-05-29 Thread via GitHub
jainankitk commented on PR #14667: URL: https://github.com/apache/lucene/pull/14667#issuecomment-2920849020 Moved changelog entry to 10.3! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Fix documentation regarding benchmark running [lucene]

2025-05-29 Thread via GitHub
jainankitk merged PR #14667: URL: https://github.com/apache/lucene/pull/14667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

Re: [PR] Fix documentation regarding benchmark running [lucene]

2025-05-29 Thread via GitHub
jainankitk commented on PR #14667: URL: https://github.com/apache/lucene/pull/14667#issuecomment-2920849691 Thanks @viliam-durina for fixing the documentation! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [I] Supporting both parentQuery and childQuery and adding childLimitPerParent in BlockJoin queries [lucene]

2025-05-29 Thread via GitHub
mkhludnev commented on issue #14565: URL: https://github.com/apache/lucene/issues/14565#issuecomment-2918935566 Hello @Jinny-Wang Thanks for your contribution. It it's still an option I vote for extending (changing) existing `ToChildBlockJoinQuery` with new behavior. - existing

Re: [PR] Use github wf to add module labels for PR based on file changes [lucene]

2025-05-29 Thread via GitHub
stefanvodita commented on PR #14101: URL: https://github.com/apache/lucene/pull/14101#issuecomment-2918941880 Linking the PR related to the question above: #14721. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [I] AbstractRangeQueryNode toQueryString not working as intended [LUCENE-6807] [lucene]

2025-05-29 Thread via GitHub
stefanvodita closed issue #7865: AbstractRangeQueryNode toQueryString not working as intended [LUCENE-6807] URL: https://github.com/apache/lucene/issues/7865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [I] AbstractRangeQueryNode toQueryString not working as intended [LUCENE-6807] [lucene]

2025-05-29 Thread via GitHub
stefanvodita commented on issue #7865: URL: https://github.com/apache/lucene/issues/7865#issuecomment-2918959878 Completed in #14697. Thank you @phb-ig for coming back to this 10 years later! -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] I cannot process the word 'ที่ผ่านมา' using the Thai tokenizer. [lucene]

2025-05-29 Thread via GitHub
rmuir commented on issue #14730: URL: https://github.com/apache/lucene/issues/14730#issuecomment-2919071183 Your problem is not caused by tokenizer, instead tokens are removed by the stopwords list. Disable the stopword removal if you don't want that. -- This is an automated message from

[I] I cannot process the word 'ที่ผ่านมา' using the Thai tokenizer. [lucene]

2025-05-29 Thread via GitHub
abchahahah opened a new issue, #14730: URL: https://github.com/apache/lucene/issues/14730 ### Description ![Image](https://github.com/user-attachments/assets/618e412a-45bf-471b-ae0c-2ac358fd9f2b) ### Version and environment details _No response_ -- This is an automate

Re: [I] I cannot process the word 'ที่ผ่านมา' using the Thai tokenizer. [lucene]

2025-05-29 Thread via GitHub
rmuir closed issue #14730: I cannot process the word 'ที่ผ่านมา' using the Thai tokenizer. URL: https://github.com/apache/lucene/issues/14730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Fix AbstractRangeQueryNode#toQueryString [lucene]

2025-05-29 Thread via GitHub
stefanvodita merged PR #14697: URL: https://github.com/apache/lucene/pull/14697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

[PR] Fix IndexSortSortedNumericDocValuesRangeQuery for int sort [lucene]

2025-05-29 Thread via GitHub
mayya-sharipova opened a new pull request, #14732: URL: https://github.com/apache/lucene/pull/14732 This query assumed that missing value is always of type long. This modifies it to allow type int as well. The test is added that fails without this change. -- This is an automated mess

Re: [PR] Fix IndexSortSortedNumericDocValuesRangeQuery for int sort [lucene]

2025-05-29 Thread via GitHub
github-actions[bot] commented on PR #14732: URL: https://github.com/apache/lucene/pull/14732#issuecomment-2920437317 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you wil

Re: [PR] Fix IndexSortSortedNumericDocValuesRangeQuery for int sort [lucene]

2025-05-29 Thread via GitHub
mayya-sharipova commented on code in PR #14732: URL: https://github.com/apache/lucene/pull/14732#discussion_r2114666927 ## lucene/core/src/test/org/apache/lucene/search/TestIndexSortSortedNumericDocValuesRangeQuery.java: ## @@ -94,6 +95,59 @@ public void testSameHitsAsPointRange

Re: [PR] Remove most uses of boolean success from IndexWriter and ReadersAndUpdates [lucene]

2025-05-29 Thread via GitHub
ChrisHegarty merged PR #14668: URL: https://github.com/apache/lucene/pull/14668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

Re: [PR] Make task executor non-final [lucene]

2025-05-29 Thread via GitHub
Shibi-bala commented on PR #14524: URL: https://github.com/apache/lucene/pull/14524#issuecomment-2920389497 @javanna Hey! I kinda disagree with: `general idea was to make concurrency as transparent as possible` since the caller thread is used alongside another exec service. I think trading

Re: [PR] Support for Re-Ranking Queries using Late Interaction Model Multi-Vectors. [lucene]

2025-05-29 Thread via GitHub
benwtrent commented on PR #14729: URL: https://github.com/apache/lucene/pull/14729#issuecomment-2919284794 I like this idea and its a good starting point for allowing late-interaction brute-force ranking (e.g reranking). -- This is an automated message from the Apache Git Service. To resp

Re: [PR] Move HitQueue in TopScoreDocCollector to a LongHeap [lucene]

2025-05-29 Thread via GitHub
gf2121 commented on code in PR #14714: URL: https://github.com/apache/lucene/pull/14714#discussion_r2113858109 ## lucene/core/src/java/org/apache/lucene/search/DocScoreEncoder.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] Use a hint to specify READONCE IOContext [lucene]

2025-05-29 Thread via GitHub
ChrisHegarty merged PR #14509: URL: https://github.com/apache/lucene/pull/14509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

Re: [PR] Move HitQueue in TopScoreDocCollector to a LongHeap [lucene]

2025-05-29 Thread via GitHub
gf2121 commented on code in PR #14714: URL: https://github.com/apache/lucene/pull/14714#discussion_r2113866926 ## lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java: ## @@ -73,23 +65,22 @@ public ScoreMode scoreMode() { public LeafCollector getLeafCollect

Re: [PR] Merge PostingsEnum and ImpactsEnum. [lucene]

2025-05-29 Thread via GitHub
gf2121 commented on code in PR #14716: URL: https://github.com/apache/lucene/pull/14716#discussion_r2114174953 ## lucene/core/src/java/org/apache/lucene/index/TermsEnum.java: ## @@ -170,11 +170,15 @@ public final PostingsEnum postings(PostingsEnum reuse) throws IOException {

[I] VirtualMachineError is swallowed in IndexWriter [lucene]

2025-05-29 Thread via GitHub
br0nstein opened a new issue, #14731: URL: https://github.com/apache/lucene/issues/14731 ### Description updateDocument handled a tragic event but the VirtualMachineError was swallowed due to the IndexWriter rollback operation called from the finally block itself throwing an exceptio

Re: [PR] [BlockJoin] Add ParentsChildrenBlockJoinQuery to support parent and c… [lucene]

2025-05-29 Thread via GitHub
msfroh commented on code in PR #14728: URL: https://github.com/apache/lucene/pull/14728#discussion_r2114495385 ## lucene/join/src/java/org/apache/lucene/search/join/ParentsChildrenBlockJoinQuery.java: ## @@ -0,0 +1,456 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [I] Supporting both parentQuery and childQuery and adding childLimitPerParent in BlockJoin queries [lucene]

2025-05-29 Thread via GitHub
Jinny-Wang commented on issue #14565: URL: https://github.com/apache/lucene/issues/14565#issuecomment-2920601532 Hi @mkhludnev > existing FilterWeight subclass can just drag second child-side scorer and count and accept matching children Are you referring to something like this? `