uschindler commented on issue #11920:
URL: https://github.com/apache/lucene/issues/11920#issuecomment-2862190434
I was able to fix the whole test by doing the following:
- In WindowsFS fall back to path as key, if the file key isn't available. I
have no yet figured out if this brings othe
uschindler commented on issue #11920:
URL: https://github.com/apache/lucene/issues/11920#issuecomment-2862192925
@rmuir do you have any other ideas - you were writing WindowsFS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
uschindler commented on PR #14627:
URL: https://github.com/apache/lucene/pull/14627#issuecomment-2862406919
@rmuir : It also works with the path (without realpath). Maybe we can just
fallback to the path instead of realpath. It should be good enough, too and
reduces overhead.
What do
uschindler commented on code in PR #14627:
URL: https://github.com/apache/lucene/pull/14627#discussion_r2079320706
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/WindowsFS.java:
##
@@ -58,7 +58,13 @@ private Object getKey(Path existing) throws IOException {
uschindler commented on PR #14627:
URL: https://github.com/apache/lucene/pull/14627#issuecomment-2862430259
I was able to remove the assume on more tests.
Basically we should posisbly now also automatically enable WindowsFS
randomly for windows, too. Will add a followup commit once Gi
uschindler commented on issue #11920:
URL: https://github.com/apache/lucene/issues/11920#issuecomment-2862170475
I am debugging. The reason for the whole failure is some spaghetti
conditions that are hard to understand.
Actually WindowsFS does not work with windows, as the Windows imp
uschindler commented on issue #11920:
URL: https://github.com/apache/lucene/issues/11920#issuecomment-2862240965
If we fallback to the path, we do not need to add special cases for file
renames. The current code checks if the filekey has changed after rename and
fixes its internal structure
uschindler commented on issue #11920:
URL: https://github.com/apache/lucene/issues/11920#issuecomment-2862308528
Here is a PR that uses toRealPath as key if the fileKey is not provided
(null). I was able to remove all "does not work on Windows assumes" in
TestIndexWriter.
--
This is an a
uschindler commented on PR #14627:
URL: https://github.com/apache/lucene/pull/14627#issuecomment-2862379899
Looks like it also passes with Windows 10 / Windows server 2022 (as used by
Github).
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
uschindler commented on PR #14627:
URL: https://github.com/apache/lucene/pull/14627#issuecomment-2862560596
Hi,
it looks like all works well with Windows and WindowsFS.
For now I left the `toReal()` path in the key generation. I am still unsure
if it won't be enough to use the plai
uschindler commented on PR #14627:
URL: https://github.com/apache/lucene/pull/14627#issuecomment-2862561374
It also works on my local Windows 11 machine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
stefanvodita merged PR #14628:
URL: https://github.com/apache/lucene/pull/14628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
uschindler commented on PR #14627:
URL: https://github.com/apache/lucene/pull/14627#issuecomment-2862658443
I'll will merge this after the tests pass here. Let's see how it behaves
long term.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
uschindler commented on PR #14627:
URL: https://github.com/apache/lucene/pull/14627#issuecomment-2862686086
Theres one small problem that makes one test fail. ACtually the backslash is
a reserved character (if used in Unix), but on Windows, it is actually the file
separator.
I will a
uschindler commented on code in PR #14627:
URL: https://github.com/apache/lucene/pull/14627#discussion_r2079517705
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/WindowsFS.java:
##
@@ -58,7 +58,13 @@ private Object getKey(Path existing) throws IOException {
rmuir commented on code in PR #14627:
URL: https://github.com/apache/lucene/pull/14627#discussion_r2079522011
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/WindowsFS.java:
##
@@ -58,7 +58,13 @@ private Object getKey(Path existing) throws IOException {
B
uschindler commented on code in PR #14627:
URL: https://github.com/apache/lucene/pull/14627#discussion_r2079517705
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/WindowsFS.java:
##
@@ -58,7 +58,13 @@ private Object getKey(Path existing) throws IOException {
uschindler opened a new pull request, #14627:
URL: https://github.com/apache/lucene/pull/14627
Windows does not support file keys (the attribute returns null). Therefore
WindowsFS cannot be used on Windows. Due to Windows 11 no longer preventing
depleting of open files, we need to be able t
rmuir commented on code in PR #14627:
URL: https://github.com/apache/lucene/pull/14627#discussion_r2079524379
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/WindowsFS.java:
##
@@ -58,7 +58,13 @@ private Object getKey(Path existing) throws IOException {
B
uschindler commented on code in PR #14627:
URL: https://github.com/apache/lucene/pull/14627#discussion_r2079517705
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/WindowsFS.java:
##
@@ -58,7 +58,13 @@ private Object getKey(Path existing) throws IOException {
uschindler commented on code in PR #14627:
URL: https://github.com/apache/lucene/pull/14627#discussion_r2079572577
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/WindowsFS.java:
##
@@ -58,7 +58,13 @@ private Object getKey(Path existing) throws IOException {
uschindler commented on code in PR #14627:
URL: https://github.com/apache/lucene/pull/14627#discussion_r2079584683
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/WindowsFS.java:
##
@@ -58,7 +58,13 @@ private Object getKey(Path existing) throws IOException {
uschindler commented on code in PR #14627:
URL: https://github.com/apache/lucene/pull/14627#discussion_r2079568663
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/WindowsFS.java:
##
@@ -58,7 +58,13 @@ private Object getKey(Path existing) throws IOException {
uschindler closed issue #11920: Test testDeleteUnusedFiles() failed in
TestIndexWriter
URL: https://github.com/apache/lucene/issues/11920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
uschindler closed issue #11920: Test testDeleteUnusedFiles() failed in
TestIndexWriter
URL: https://github.com/apache/lucene/issues/11920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
uschindler merged PR #14627:
URL: https://github.com/apache/lucene/pull/14627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
uschindler commented on PR #14627:
URL: https://github.com/apache/lucene/pull/14627#issuecomment-2862891006
I am out for lunch and only have my smartphone so can't cherry 🍒 pick to
stable branch. Will do this when back at home, unless somebody wants to step in
to silence Jenkins.
--
This
uschindler commented on code in PR #14627:
URL: https://github.com/apache/lucene/pull/14627#discussion_r2079584683
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/WindowsFS.java:
##
@@ -58,7 +58,13 @@ private Object getKey(Path existing) throws IOException {
jainankitk commented on PR #14626:
URL: https://github.com/apache/lucene/pull/14626#issuecomment-2862080922
> I think I liked the previous version better - this wasn't unreadable at
all to my eyes, typical boolean expression?
You're right. In hindsight that does read better. I probabl
gf2121 opened a new issue, #14630:
URL: https://github.com/apache/lucene/issues/14630
### Description
I'm seeing a big performance change (mostly regression) on 2025.05.01
benchmark, without an annotation. Is this expected?
https://benchmarks.mikemccandless.com/2025.05.01.10.59
benwtrent commented on issue #14180:
URL: https://github.com/apache/lucene/issues/14180#issuecomment-2863036189
> Has the problem been resolved? Will the next version of Elasticsearch fix
this issue?
It has been resolved in Lucene. There is no set fix version for anything
that depend
thecoop opened a new pull request, #14629:
URL: https://github.com/apache/lucene/pull/14629
Backport #14510 to 10.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
uschindler commented on issue #11920:
URL: https://github.com/apache/lucene/issues/11920#issuecomment-2862905437
Fixed. The issue was that file keys are optional in the java file attributes.
Adding a fallback to the path makes WindowsFS also work on Windows so we can
apply WindowsFS also
benwtrent commented on PR #14527:
URL: https://github.com/apache/lucene/pull/14527#issuecomment-2863042916
> but the float array of the scores will not be passed out. Do I need to
change FloatArrayList to MaxSizedFloatArrayList?
I don't understand this. How does the FloatArrayList byp
mikemccand commented on PR #14627:
URL: https://github.com/apache/lucene/pull/14627#issuecomment-2863041997
> I am out for lunch and only have my smartphone so can't cherry 🍒 pick to
stable branch. Will do this when back at home, unless somebody wants to step in
to silence Jenkins.
weizijun commented on PR #14527:
URL: https://github.com/apache/lucene/pull/14527#issuecomment-2863408186
> I don't understand this. How does the FloatArrayList bypass the
overallocation possible via `ArrayUtils.grow`? Its the same structure right?
and for every node there is a score.
gsmiller commented on PR #14614:
URL: https://github.com/apache/lucene/pull/14614#issuecomment-2863810564
> so this basically extends the API so hashCount can be supplied rather than
always assumed to be 1?
That's right. (But I think we should get rid of the version that assumes
1...
gf2121 merged PR #14596:
URL: https://github.com/apache/lucene/pull/14596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
markrmiller commented on issue #13797:
URL: https://github.com/apache/lucene/issues/13797#issuecomment-2865097554
Thank you for your question, Vigya.
> Will v16 still need to ship the 14-format code?
Yes—until a new on-disk break forces `MIN_SUPPORTED_MAJOR` to move again.
>
ebradshaw commented on code in PR #14609:
URL: https://github.com/apache/lucene/pull/14609#discussion_r2080657472
##
lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java:
##
@@ -580,4 +557,111 @@ public final String toString(String field) {
* @return human read
jainankitk commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2864277665
> > dangoslen/changelog-enforcer@v3 is not allowed to be used in
apache/lucene
>
> Apache projects are not allowed to use arbitrary actions for security
reasons, please ta
stefanvodita commented on issue #13898:
URL: https://github.com/apache/lucene/issues/13898#issuecomment-2863442745
I pushed a few more fixes in #14628. We have our first successful instance
of the changelog being validated and a milestone extracted from it
([logs](https://github.com/apache/
gf2121 merged PR #14563:
URL: https://github.com/apache/lucene/pull/14563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
ebradshaw commented on code in PR #14609:
URL: https://github.com/apache/lucene/pull/14609#discussion_r2080658986
##
lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java:
##
@@ -580,4 +557,111 @@ public final String toString(String field) {
* @return human read
ebradshaw commented on PR #14609:
URL: https://github.com/apache/lucene/pull/14609#issuecomment-2864750920
I think we're good now. Let me know if you guys see anything else, and
thanks for the quick review!
--
This is an automated message from the Apache Git Service.
To respond to the me
github-actions[bot] commented on PR #14452:
URL: https://github.com/apache/lucene/pull/14452#issuecomment-2864763405
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
github-actions[bot] commented on PR #14550:
URL: https://github.com/apache/lucene/pull/14550#issuecomment-2864763268
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
github-actions[bot] commented on PR #14356:
URL: https://github.com/apache/lucene/pull/14356#issuecomment-2864763458
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
github-actions[bot] commented on PR #14548:
URL: https://github.com/apache/lucene/pull/14548#issuecomment-2864763288
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
github-actions[bot] commented on PR #14532:
URL: https://github.com/apache/lucene/pull/14532#issuecomment-2864763311
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
github-actions[bot] commented on PR #14525:
URL: https://github.com/apache/lucene/pull/14525#issuecomment-2864763345
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
51 matches
Mail list logo
