jainankitk commented on PR #14626: URL: https://github.com/apache/lucene/pull/14626#issuecomment-2862080922
> I think I liked the previous version better - this wasn't unreadable at all to my eyes, typical boolean expression? You're right. In hindsight that does read better. I probably wanted to insist on the fact that comparison is skipped if crosses = true, and very common coding pattern for that is: ``` if (x == null || x.something) ``` but I guess it is pretty clear otherwise as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
