Re: [PR] Disable sort optimization when tracking all docs [lucene]

github-actions[bot] commented on PR #14395: URL: https://github.com/apache/lucene/pull/14395#issuecomment-2831654167 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Provide better impacts for fields indexed with IndexOptions.DOCS [lucene]

jpountz commented on PR #14511: URL: https://github.com/apache/lucene/pull/14511#issuecomment-2830429994 I hope you don't mind, I updated this PR title and description to better reflect the change. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] Fix leadCost calculation in BooleanScorerSupplier.requiredBulkScorer [lucene]

jpountz commented on code in PR #14543: URL: https://github.com/apache/lucene/pull/14543#discussion_r2060222310 ## lucene/core/src/test/org/apache/lucene/search/TestBoolean2ScorerSupplier.java: ## @@ -315,6 +318,9 @@ public void testDisjunctionLeadCost() throws IOException {

Re: [PR] Ensuring skip list is read for fields indexed with only DOCS [lucene]

jpountz commented on PR #14511: URL: https://github.com/apache/lucene/pull/14511#issuecomment-2830415622 This sounds safe enough for 10.2.1 for me. Can you move the CHANGES entry to 10.2.1 then? cc @ChrisHegarty -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] add RawTFSimilarity class [lucene]

cpoerschke commented on PR #13749: URL: https://github.com/apache/lucene/pull/13749#issuecomment-2830589655 > Your reference to `DelimitedTermFrequencyTokenFilter` suggests that the freq here is more a feature than an actual frequency of a term in a doc. From an API perspective, this would

Re: [PR] Provide better impacts for fields indexed with IndexOptions.DOCS [lucene]

ChrisHegarty commented on PR #14511: URL: https://github.com/apache/lucene/pull/14511#issuecomment-2830590012 > @ChrisHegarty @jpountz Moved the change log to 10.2.1 Eh! I think you moved it to 10.2.0, rather than 10.2.1. -- This is an automated message from the Apache Git Service.

[PR] [Backport] Provide better impacts for fields indexed with IndexOptions.DOCS [lucene]

gf2121 opened a new pull request, #14557: URL: https://github.com/apache/lucene/pull/14557 Backport https://github.com/apache/lucene/pull/14511 to branch_10x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [I] [Bug] Lead cost in boolean conjunction queries can be miscalculated [lucene]

ChrisHegarty closed issue #14542: [Bug] Lead cost in boolean conjunction queries can be miscalculated URL: https://github.com/apache/lucene/issues/14542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Fix leadCost calculation in BooleanScorerSupplier.requiredBulkScorer [lucene]

ChrisHegarty merged PR #14543: URL: https://github.com/apache/lucene/pull/14543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

Re: [PR] Provide better impacts for fields indexed with IndexOptions.DOCS [lucene]

gf2121 commented on PR #14511: URL: https://github.com/apache/lucene/pull/14511#issuecomment-2830734669 To be clear, i raised https://github.com/apache/lucene/pull/14557 and https://github.com/apache/lucene/pull/14558 for backporting. I plan to merge this now if no one objects. -- This i

Re: [PR] Provide better impacts for fields indexed with IndexOptions.DOCS [lucene]

gf2121 commented on PR #14511: URL: https://github.com/apache/lucene/pull/14511#issuecomment-2830738175 @expani could you resolve the conflicts so that i can merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2059828062 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [I] Examine the affects of MADV_RANDOM when MGLRU is enabled in Linux kernel [lucene]

mikemccand commented on issue #14408: URL: https://github.com/apache/lucene/issues/14408#issuecomment-2830109470 > > The Linux change targets both MGLRU and normal LRU. The impact is more pronounced in MGLRU, as page reclamation is more aggressive there. However, the semantic change for thi

Re: [I] Examine the affects of MADV_RANDOM when MGLRU is enabled in Linux kernel [lucene]

rmuir commented on issue #14408: URL: https://github.com/apache/lucene/issues/14408#issuecomment-2830144654 > +1 to work towards this more general fix. But, sheesh, it looks so complicated, depending on hot vs cold use case, preloading or not, which part of the Lucene index (KNN, terms, pos

Re: [PR] Ensuring skip list is read for fields indexed with only DOCS [lucene]

expani commented on PR #14511: URL: https://github.com/apache/lucene/pull/14511#issuecomment-2830167911 Addressed comments. I want to backport these to `9.12.x` and `10.2.x` as well. Will open separate PRs for the same. -- This is an automated message from the Apache Git Serv

Re: [I] Smoke tester requiring Python 3.12+ [lucene]

stefanvodita commented on issue #14556: URL: https://github.com/apache/lucene/issues/14556#issuecomment-2830293555 I see we have 3.12 [configured](https://github.com/apache/lucene/blob/92d79d47cbd238137ec136f6947c0c9e86003ce0/dev-tools/scripts/pyproject.toml#L2) and at least for me that's a

Re: [I] Smoke tester requiring Python 3.12+ [lucene]

rmuir commented on issue #14556: URL: https://github.com/apache/lucene/issues/14556#issuecomment-2830316620 I think there is a way, there is even some existing logic to do it (I suspect it has the wrong version set). Additionally, I know existing logic uses an outdated method to check the p

Re: [PR] Fix leadCost calculation in BooleanScorerSupplier.requiredBulkScorer [lucene]

benwtrent commented on code in PR #14543: URL: https://github.com/apache/lucene/pull/14543#discussion_r2060181757 ## lucene/core/src/java/org/apache/lucene/search/BooleanScorerSupplier.java: ## @@ -78,11 +86,7 @@ private long computeCost() { return minRequiredCost.getAsLo

Re: [PR] Fix leadCost calculation in BooleanScorerSupplier.requiredBulkScorer [lucene]

benwtrent commented on code in PR #14543: URL: https://github.com/apache/lucene/pull/14543#discussion_r2060183537 ## lucene/core/src/test/org/apache/lucene/search/TestBoolean2ScorerSupplier.java: ## @@ -315,6 +318,9 @@ public void testDisjunctionLeadCost() throws IOException {

Re: [PR] Provide better impacts for fields indexed with IndexOptions.DOCS [lucene]

expani commented on PR #14511: URL: https://github.com/apache/lucene/pull/14511#issuecomment-2830552012 >I hope you don't mind, I updated this PR title and description to better reflect the change. Not at all. Thanks for taking the time to explain the different pieces of this code.

Re: [PR] Provide better impacts for fields indexed with IndexOptions.DOCS [lucene]

expani commented on PR #14511: URL: https://github.com/apache/lucene/pull/14511#issuecomment-2830554353 @ChrisHegarty @jpountz Moved the change log to 10.2.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Provide better impacts for fields indexed with IndexOptions.DOCS [lucene]

ChrisHegarty commented on PR #14511: URL: https://github.com/apache/lucene/pull/14511#issuecomment-2830633097 > This sounds safe enough for 10.2.1 for me. Can you move the CHANGES entry to 10.2.1 then? cc @ChrisHegarty What am I missing? This is not applicable to 10.2.1, since the on

Re: [PR] Provide better impacts for fields indexed with IndexOptions.DOCS [lucene]

expani commented on PR #14511: URL: https://github.com/apache/lucene/pull/14511#issuecomment-2830623186 Oops hadn't rebased with main. Fixed it now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Provide better impacts for fields indexed with IndexOptions.DOCS [lucene]

expani commented on PR #14511: URL: https://github.com/apache/lucene/pull/14511#issuecomment-2830648760 >What am I missing? This is not applicable to 10.2.1, since the only changed file is Lucene103PostingsReader.java which is not present in 10.2 ! Did the rebase mess something up ?

Re: [PR] Provide better impacts for fields indexed with IndexOptions.DOCS [lucene]

gf2121 commented on PR #14511: URL: https://github.com/apache/lucene/pull/14511#issuecomment-2830669459 > Lucene103PostingsReader.java which is not present in 10.2 Yes, we have not backport `Lucene103PostingReader`, see https://github.com/apache/lucene/pull/14333#issuecomment-28246448

Re: [PR] Provide better impacts for fields indexed with IndexOptions.DOCS [lucene]

expani commented on PR #14511: URL: https://github.com/apache/lucene/pull/14511#issuecomment-2830685389 I made the same change in `Lucene101PostingsReader` as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Provide better impacts for fields indexed with IndexOptions.DOCS [lucene]

gf2121 merged PR #14511: URL: https://github.com/apache/lucene/pull/14511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [I] Term Query is slower post Lucene 9.12 for fields with IndexOptions.DOCS [lucene]

gf2121 closed issue #14445: Term Query is slower post Lucene 9.12 for fields with IndexOptions.DOCS URL: https://github.com/apache/lucene/issues/14445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] Term Query is slower post Lucene 9.12 for fields with IndexOptions.DOCS [lucene]

gf2121 closed issue #14445: Term Query is slower post Lucene 9.12 for fields with IndexOptions.DOCS URL: https://github.com/apache/lucene/issues/14445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [Backport] Provide better impacts for fields indexed with IndexOptions.DOCS [lucene]

gf2121 merged PR #14558: URL: https://github.com/apache/lucene/pull/14558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[PR] [Backport] Provide better impacts for fields indexed with IndexOptions.DOCS [lucene]

gf2121 opened a new pull request, #14558: URL: https://github.com/apache/lucene/pull/14558 Backport https://github.com/apache/lucene/pull/14511 to branch_10_2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [Backport] Provide better impacts for fields indexed with IndexOptions.DOCS [lucene]

gf2121 merged PR #14557: URL: https://github.com/apache/lucene/pull/14557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Ensuring skip list is read for fields indexed with only DOCS [lucene]

expani commented on code in PR #14511: URL: https://github.com/apache/lucene/pull/14511#discussion_r2059790054 ## lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java: ## @@ -66,13 +67,20 @@ public final class Lucene103PostingsReader extends Post

Re: [PR] Ensuring skip list is read for fields indexed with only DOCS [lucene]

expani commented on code in PR #14511: URL: https://github.com/apache/lucene/pull/14511#discussion_r2059808880 ## lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java: ## @@ -1286,14 +1298,11 @@ public long cost() { @Override

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2059809065 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Ensuring skip list is read for fields indexed with only DOCS [lucene]

expani commented on code in PR #14511: URL: https://github.com/apache/lucene/pull/14511#discussion_r2059897538 ## lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java: ## @@ -1286,14 +1298,11 @@ public long cost() { @Override

Re: [PR] Fix leadCost calculation in BooleanScorerSupplier.requiredBulkScorer [lucene]

jpountz commented on PR #14543: URL: https://github.com/apache/lucene/pull/14543#issuecomment-2829978102 @peteralfonsi I pushed tests to your branch so that this change has a chance to make it to 10.2. I hope you don't mind. We already had good tests for `ScorerSupplier#scorer`, I just exte

Re: [PR] Logic for collecting Histogram efficiently using Point Trees [lucene]

stefanvodita merged PR #14439: URL: https://github.com/apache/lucene/pull/14439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

[I] Smoke tester requiring Python 3.12+ [lucene]

stefanvodita opened a new issue, #14556: URL: https://github.com/apache/lucene/issues/14556 #14326 added a [line in scriptutil](https://github.com/apache/lucene/blob/92d79d47cbd238137ec136f6947c0c9e86003ce0/dev-tools/scripts/scriptutil.py#L26) that imports `override` from `typing`, which wa

Re: [PR] Ensuring skip list is read for fields indexed with only DOCS [lucene]

expani commented on PR #14511: URL: https://github.com/apache/lucene/pull/14511#issuecomment-2829961538 Added the changes entry. >undo the new line in SlowImpactsEnum? ``` ./gradlew tidy ./gradlew spotlessApply ./gradlew spotlessJavaApply ``` All these command

Re: [PR] Ensuring skip list is read for fields indexed with only DOCS [lucene]

jpountz commented on code in PR #14511: URL: https://github.com/apache/lucene/pull/14511#discussion_r2059900940 ## lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java: ## @@ -1286,14 +1298,11 @@ public long cost() { @Override

Re: [PR] Ensuring skip list is read for fields indexed with only DOCS [lucene]

expani commented on code in PR #14511: URL: https://github.com/apache/lucene/pull/14511#discussion_r2059942355 ## lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java: ## @@ -1286,14 +1298,11 @@ public long cost() { @Override

Re: [PR] Fix leadCost calculation in BooleanScorerSupplier.requiredBulkScorer [lucene]

jpountz commented on PR #14543: URL: https://github.com/apache/lucene/pull/14543#issuecomment-2829992135 For reference, the new tests found a similar bug with disjunctive queries that configure a minimum number of matching clauses, so I fixed it too. -- This is an automated message from t

Re: [PR] Ensuring skip list is read for fields indexed with only DOCS [lucene]

expani commented on code in PR #14511: URL: https://github.com/apache/lucene/pull/14511#discussion_r2059808880 ## lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java: ## @@ -1286,14 +1298,11 @@ public long cost() { @Override

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

thecoop commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2059809065 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [PR] Allow docID == NO_MORE_DOCS for asserting leaf reader [lucene]

gf2121 merged PR #14555: URL: https://github.com/apache/lucene/pull/14555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Fix leadCost calculation in BooleanScorerSupplier.requiredBulkScorer [lucene]

peteralfonsi commented on PR #14543: URL: https://github.com/apache/lucene/pull/14543#issuecomment-2830980718 @jpountz Thanks for the help with the tests - didn't realize 10.2 was coming soon. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Enhancing the Turkish stop word list with additional common words [lucene]

stefanvodita commented on code in PR #14549: URL: https://github.com/apache/lucene/pull/14549#discussion_r2060613797 ## lucene/analysis/common/src/resources/org/apache/lucene/analysis/tr/stopwords.txt: ## @@ -171,42 +372,108 @@ siz sizden sizi sizin -şey -şeyden -şeyi -şeyler

Re: [PR] Enhancing the Turkish stop word list with additional common words [lucene]

bahadirborasahin commented on code in PR #14549: URL: https://github.com/apache/lucene/pull/14549#discussion_r2060660639 ## lucene/analysis/common/src/resources/org/apache/lucene/analysis/tr/stopwords.txt: ## @@ -171,42 +372,108 @@ siz sizden sizi sizin -şey -şeyden -şeyi -şe