benwtrent commented on code in PR #14543:
URL: https://github.com/apache/lucene/pull/14543#discussion_r2060183537


##########
lucene/core/src/test/org/apache/lucene/search/TestBoolean2ScorerSupplier.java:
##########
@@ -315,6 +318,9 @@ public void testDisjunctionLeadCost() throws IOException {
     new BooleanScorerSupplier(
             new FakeWeight(), subs, RandomPicks.randomFrom(random(), 
ScoreMode.values()), 0, 100)
         .get(100); // triggers assertions as a side-effect
+    new BooleanScorerSupplier(
+            new FakeWeight(), subs, RandomPicks.randomFrom(random(), 
ScoreMode.values()), 0, 100)
+        .bulkScorer(); // triggers assertions as a side-effect

Review Comment:
   ```
   TestBoolean2ScorerSupplier > testDisjunctionLeadCost FAILED
       java.lang.AssertionError: FakeLazyScorer(cost=42,leadCost=54) 
expected:<54> but was:<9223372036854775807>
           at 
__randomizedtesting.SeedInfo.seed([59321C032B75088A:CB8AA4FC1AF92C0A]:0)
           at org.junit.Assert.fail(Assert.java:89)
           at org.junit.Assert.failNotEquals(Assert.java:835)
           at org.junit.Assert.assertEquals(Assert.java:647)
           at 
org.apache.lucene.search.TestBoolean2ScorerSupplier$FakeScorerSupplier.get(TestBoolean2ScorerSupplier.java:108)
           at 
org.apache.lucene.search.BooleanScorerSupplier.optionalBulkScorer(BooleanScorerSupplier.java:294)
           at 
org.apache.lucene.search.BooleanScorerSupplier.booleanScorer(BooleanScorerSupplier.java:216)
           at 
org.apache.lucene.search.BooleanScorerSupplier.bulkScorer(BooleanScorerSupplier.java:178)
           at 
org.apache.lucene.search.TestBoolean2ScorerSupplier.testDisjunctionLeadCost(TestBoolean2ScorerSupplier.java:323)
           at 
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
   ```
   
   Is failing?
   
   ```
   gradlew test --tests TestBoolean2ScorerSupplier.testDisjunctionLeadCost 
-Dtests.seed=59321C032B75088A -Dtests.locale=yrl-VE -Dtests.timezone=Etc/GMT-14 
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to