Re: [PR] Introduce a mapping to map sparse labels to a continuous range [lucene]

mikemccand commented on PR #14494: URL: https://github.com/apache/lucene/pull/14494#issuecomment-2816860016 Whoa, exciting! I will try to review soon! Thanks @gf2121. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Make TestIndexWriterDelete.testDeleteAllRepeated a monster test and force FSDirectory to prevent OOM. [lucene]

rmuir commented on PR #14526: URL: https://github.com/apache/lucene/pull/14526#issuecomment-2816779697 fwiw: here is my tmpfs setup, which avoids breaking my SSD. This one is 7 years old now. I've got 5MB of trash from lucene builds after 9 days uptime, plenty of trash from other less-behav

Re: [PR] Use a non-deprecated assertThat, and change several test assertions to use assertThat [lucene]

dweiss commented on PR #14518: URL: https://github.com/apache/lucene/pull/14518#issuecomment-2816759024 I have taken another look. The one thing I would revert is replacing assertEquals with hamcrest matchers - it is indeed the same functionality, the same output message and more verbose co

Re: [PR] Use a non-deprecated assertThat, and change several test assertions to use assertThat [lucene]

dweiss commented on code in PR #14518: URL: https://github.com/apache/lucene/pull/14518#discussion_r2051512251 ## lucene/core/src/test/org/apache/lucene/document/TestDocument.java: ## @@ -207,7 +219,7 @@ public void testGetValuesForIndexedDocument() throws Exception { //

[PR] Make TestIndexWriterDelete.testDeleteAllRepeated a monster test and force FSDirectory to prevent OOM. [lucene]

dweiss opened a new pull request, #14526: URL: https://github.com/apache/lucene/pull/14526 Workaround for #14508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [I] Update jenkins configurations after min JDK version bump [lucene]

dweiss closed issue #14314: Update jenkins configurations after min JDK version bump URL: https://github.com/apache/lucene/issues/14314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [I] Tone down TestIndexWriterDelete.testDeleteAllRepeated (OOMs sometimes) [lucene]

dweiss commented on issue #14508: URL: https://github.com/apache/lucene/issues/14508#issuecomment-2816765665 I've filed a PR to move this test to a monster test and force FSDirectory. Don't know any better but it seems excessive. -- This is an automated message from the Apache Git Service

Re: [I] Odd nightly error in buildAndPushRelease: NoSuchMethodException: no such method: java.lang.invoke.MethodHandle.linkToStatic [lucene]

dweiss closed issue #13792: Odd nightly error in buildAndPushRelease: NoSuchMethodException: no such method: java.lang.invoke.MethodHandle.linkToStatic URL: https://github.com/apache/lucene/issues/13792 -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [I] Odd nightly error in buildAndPushRelease: NoSuchMethodException: no such method: java.lang.invoke.MethodHandle.linkToStatic [lucene]

dweiss commented on issue #13792: URL: https://github.com/apache/lucene/issues/13792#issuecomment-2816766359 Closing, haven't seen this one in a while. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [I] Strange stack traces for new bitset focused doc iterators [lucene]

benwtrent closed issue #14517: Strange stack traces for new bitset focused doc iterators URL: https://github.com/apache/lucene/issues/14517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [I] Strange stack traces for new bitset focused doc iterators [lucene]

benwtrent closed issue #14517: Strange stack traces for new bitset focused doc iterators URL: https://github.com/apache/lucene/issues/14517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Correct TermOrdValComparator competitive iterator intoBitSet implementation [lucene]

benwtrent merged PR #14523: URL: https://github.com/apache/lucene/pull/14523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

Re: [I] Run a workflow on dependabot's PRs (gradlew updateLicenses writeLocks) [lucene]

dweiss commented on issue #14506: URL: https://github.com/apache/lucene/issues/14506#issuecomment-2817030841 This is possible. I've implemented it on my fork and could run an update-after-pr action: https://github.com/dweiss/lucene/pull/27 There is some trickery in how to avoid run

Re: [PR] Shore up some intoBitSet impls and add paranoid protections [lucene]

benwtrent commented on code in PR #14523: URL: https://github.com/apache/lucene/pull/14523#discussion_r2051464595 ## lucene/core/src/java/org/apache/lucene/search/DisjunctionDISIApproximation.java: ## @@ -146,6 +146,9 @@ public int advance(int target) throws IOException { @Ov

Re: [PR] Correct TermOrdValComparator competitive iterator intoBitSet implementation [lucene]

benwtrent commented on code in PR #14523: URL: https://github.com/apache/lucene/pull/14523#discussion_r2051473858 ## lucene/core/src/java/org/apache/lucene/search/comparators/TermOrdValComparator.java: ## @@ -524,17 +524,21 @@ public int advance(int target) throws IOException {

Re: [PR] Correct TermOrdValComparator competitive iterator intoBitSet implementation [lucene]

gf2121 commented on code in PR #14523: URL: https://github.com/apache/lucene/pull/14523#discussion_r2051477090 ## lucene/core/src/test/org/apache/lucene/search/comparators/TestTermOrdValComparator.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF)