dweiss commented on PR #14518: URL: https://github.com/apache/lucene/pull/14518#issuecomment-2816759024
I have taken another look. The one thing I would revert is replacing assertEquals with hamcrest matchers - it is indeed the same functionality, the same output message and more verbose code. Other changes seem more palatable to me - like array containment cleaned up (and this should result in a better error message, should something wrong happen), assertTrue conditions replaced with equality checks (so that values are reported, not just failed assertion). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
