Re: [PR] Use a hint to specify READONCE IOContext [lucene]

2025-04-16 Thread via GitHub
uschindler commented on PR #14509: URL: https://github.com/apache/lucene/pull/14509#issuecomment-2808928300 Could we get some context/issue what this is about? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] OptimisticKnnVectorQuery [lucene]

2025-04-16 Thread via GitHub
benwtrent commented on PR #14226: URL: https://github.com/apache/lucene/pull/14226#issuecomment-2809670383 > , I'm in favor of fixing it as a magic number that replicates something close to the current behavior (or better recall if we can and retain the same latency as we found with lambda=

[PR] Change uses of withReadAdvice to use hints instead [lucene]

2025-04-16 Thread via GitHub
thecoop opened a new pull request, #14510: URL: https://github.com/apache/lucene/pull/14510 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] OptimisticKnnVectorQuery [lucene]

2025-04-16 Thread via GitHub
msokolov commented on PR #14226: URL: https://github.com/apache/lucene/pull/14226#issuecomment-2810290056 As far as making this the default, that sounds OK to me, but let's not backport until we've had a chance to verify no harm for a while in some pre-production environments -- This is

[PR] [Bug] Fix for stored fields force merge regression [lucene]

2025-04-16 Thread via GitHub
bharath-techie opened a new pull request, #14512: URL: https://github.com/apache/lucene/pull/14512 ### Description Resolves https://github.com/apache/lucene/issues/14463 I have made changes similar to https://github.com/apache/lucene/pull/13985 to update read advice to sequent

[PR] Use a hint to specify READONCE IOContext [lucene]

2025-04-16 Thread via GitHub
thecoop opened a new pull request, #14509: URL: https://github.com/apache/lucene/pull/14509 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] Use a hint to specify READONCE IOContext [lucene]

2025-04-16 Thread via GitHub
thecoop commented on PR #14509: URL: https://github.com/apache/lucene/pull/14509#issuecomment-2808933733 This is following on from https://github.com/apache/lucene/pull/14482. This is in draft, as I wanted to see that this refactoring worked cleanly based on the changes in #14482, but needs

Re: [I] Tone down TestIndexWriterDelete.testDeleteAllRepeated (OOMs sometimes) [lucene]

2025-04-16 Thread via GitHub
uschindler commented on issue #14508: URL: https://github.com/apache/lucene/issues/14508#issuecomment-2809265915 > [@msfroh](https://github.com/msfroh) would you know how to tackle this better than forcing FSDirectory in this test? Policeman Jenkins poor NVME disk!!! The new serve

Re: [PR] deps(java): bump com.carrotsearch.randomizedtesting:randomizedtesting-runner from 2.8.1 to 2.8.3 [lucene]

2025-04-16 Thread via GitHub
dweiss merged PR #14504: URL: https://github.com/apache/lucene/pull/14504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] deps(java): bump xerces:xercesImpl from 2.12.0 to 2.12.2 [lucene]

2025-04-16 Thread via GitHub
dweiss merged PR #14502: URL: https://github.com/apache/lucene/pull/14502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[PR] Ensuring skip list is read for fields indexed with only DOCS [lucene]

2025-04-16 Thread via GitHub
expani opened a new pull request, #14511: URL: https://github.com/apache/lucene/pull/14511 ### Description Fix for https://github.com/apache/lucene/issues/14445 Falling back to return a SlowImpactsEnum for all default cases but ensuring skip data is read for case where field i

Re: [PR] Ensuring skip list is read for fields indexed with only DOCS [lucene]

2025-04-16 Thread via GitHub
expani commented on code in PR #14511: URL: https://github.com/apache/lucene/pull/14511#discussion_r2047829308 ## lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java: ## @@ -1310,7 +1317,7 @@ public List getImpacts(int level) { r

Re: [PR] Ensuring skip list is read for fields indexed with only DOCS [lucene]

2025-04-16 Thread via GitHub
msfroh commented on code in PR #14511: URL: https://github.com/apache/lucene/pull/14511#discussion_r2047793102 ## lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java: ## @@ -1310,7 +1317,7 @@ public List getImpacts(int level) { r

[I] IndexWriter forceMergeDeletes should return its MergeSpec [lucene]

2025-04-16 Thread via GitHub
vigyasharma opened a new issue, #14515: URL: https://github.com/apache/lucene/issues/14515 IndexWriter provides a `forceMergeDeletes` API which triggers force merging of all segments that have deleted documents, allowing users to expunge deletes up to a configurable delete percentage (set v

Re: [I] Backport Bot [lucene]

2025-04-16 Thread via GitHub
jainankitk commented on issue #14496: URL: https://github.com/apache/lucene/issues/14496#issuecomment-2811880891 We have similar backport workflow in OpenSearch, that might be useful - https://github.com/opensearch-project/OpenSearch/blob/main/.github/workflows/backport.yml. Just need to ad