Re: [I] A little optimization about LZ4 [lucene]

2025-03-22 Thread via GitHub
kkewwei commented on issue #14347: URL: https://github.com/apache/lucene/issues/14347#issuecomment-2743128817 `I` am wondering if the default for BEST_SPEED should be using preset dict as that compromises speed for compression` It appears that certain scenarios might not be entirely a

Re: [PR] Optimize ParallelLeafReader to improve term vector fetching efficienc [lucene]

2025-03-22 Thread via GitHub
vigyasharma commented on code in PR #14373: URL: https://github.com/apache/lucene/pull/14373#discussion_r2008971160 ## lucene/core/src/java/org/apache/lucene/index/ParallelLeafReader.java: ## @@ -348,15 +348,24 @@ public void prefetch(int docID) throws IOException { @Over

Re: [PR] Clean up junk from gradle's user home (~/.gradle/.tmp). #14385 [lucene]

2025-03-22 Thread via GitHub
uschindler commented on code in PR #14387: URL: https://github.com/apache/lucene/pull/14387#discussion_r2008716613 ## gradle/hacks/wipe-temp.gradle: ## @@ -14,15 +14,35 @@ * See the License for the specific language governing permissions and * limitations under the License.

Re: [PR] Implement #docIDRunEnd() on PostingsEnum. [lucene]

2025-03-22 Thread via GitHub
gf2121 commented on code in PR #14390: URL: https://github.com/apache/lucene/pull/14390#discussion_r2008706856 ## lucene/core/src/java/org/apache/lucene/codecs/lucene101/Lucene101PostingsReader.java: ## @@ -1059,6 +1059,29 @@ private void bufferIntoBitSet(int start, int end, Fi

Re: [PR] build: generate CaseFolding.java from "gradle regenerate" [lucene]

2025-03-22 Thread via GitHub
rmuir commented on code in PR #14384: URL: https://github.com/apache/lucene/pull/14384#discussion_r2008648506 ## lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java: ## @@ -759,23 +759,14 @@ private Automaton toAutomaton( * @return the original codepoint and th

Re: [PR] Optimize ParallelLeafReader to improve term vector fetching efficienc [lucene]

2025-03-22 Thread via GitHub
DivyanshIITB commented on PR #14373: URL: https://github.com/apache/lucene/pull/14373#issuecomment-2745182601 > Changes look good to me. Can you run `./gradlew tidy` to fix formatting issues, and add a changes entry before we merge this? I successfully ran `./gradlew tidy` and the bui

Re: [PR] Implement #docIDRunEnd() on PostingsEnum. [lucene]

2025-03-22 Thread via GitHub
jpountz commented on code in PR #14390: URL: https://github.com/apache/lucene/pull/14390#discussion_r2008757738 ## lucene/core/src/java/org/apache/lucene/codecs/lucene101/Lucene101PostingsReader.java: ## @@ -1059,6 +1059,29 @@ private void bufferIntoBitSet(int start, int end, F

Re: [PR] Implement #docIDRunEnd() on PostingsEnum. [lucene]

2025-03-22 Thread via GitHub
jpountz commented on code in PR #14390: URL: https://github.com/apache/lucene/pull/14390#discussion_r2008757161 ## lucene/core/src/java/org/apache/lucene/index/CheckIndex.java: ## @@ -2458,6 +2469,31 @@ private static void checkTermsIntersect(Terms terms, Automaton automaton, B

Re: [PR] Implement #docIDRunEnd() on PostingsEnum. [lucene]

2025-03-22 Thread via GitHub
gf2121 commented on code in PR #14390: URL: https://github.com/apache/lucene/pull/14390#discussion_r2008767598 ## lucene/core/src/java/org/apache/lucene/codecs/lucene101/Lucene101PostingsReader.java: ## @@ -1059,6 +1059,29 @@ private void bufferIntoBitSet(int start, int end, Fi

Re: [PR] Implement #docIDRunEnd() on PostingsEnum. [lucene]

2025-03-22 Thread via GitHub
gf2121 commented on code in PR #14390: URL: https://github.com/apache/lucene/pull/14390#discussion_r2008772414 ## lucene/core/src/java/org/apache/lucene/index/CheckIndex.java: ## @@ -2458,6 +2469,31 @@ private static void checkTermsIntersect(Terms terms, Automaton automaton, By

Re: [PR] Optimize ParallelLeafReader to improve term vector fetching efficienc [lucene]

2025-03-22 Thread via GitHub
DivyanshIITB commented on code in PR #14373: URL: https://github.com/apache/lucene/pull/14373#discussion_r2008721150 ## lucene/core/src/java/org/apache/lucene/index/ParallelLeafReader.java: ## @@ -348,15 +348,24 @@ public void prefetch(int docID) throws IOException { @Ove

Re: [PR] A specialized Trie for Block Tree Index [lucene]

2025-03-22 Thread via GitHub
gf2121 commented on code in PR #14333: URL: https://github.com/apache/lucene/pull/14333#discussion_r2006876856 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/TrieBuilder.java: ## @@ -0,0 +1,552 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Optimize ParallelLeafReader to improve term vector fetching efficienc [lucene]

2025-03-22 Thread via GitHub
vigyasharma commented on code in PR #14373: URL: https://github.com/apache/lucene/pull/14373#discussion_r2008971507 ## lucene/CHANGES.txt: ## @@ -35,6 +35,10 @@ Optimizations - * GITHUB#14011: Reduce allocation rate in HNSW concurrent merge. (Viliam Durina

Re: [PR] Cover all DataType [lucene]

2025-03-22 Thread via GitHub
LuXugang commented on PR #14091: URL: https://github.com/apache/lucene/pull/14091#issuecomment-2745976269 Sorry for misssing backreport this issue, I would fix it soon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th