jpountz commented on code in PR #14390: URL: https://github.com/apache/lucene/pull/14390#discussion_r2008757161
########## lucene/core/src/java/org/apache/lucene/index/CheckIndex.java: ########## @@ -2458,6 +2469,31 @@ private static void checkTermsIntersect(Terms terms, Automaton automaton, BytesR } } + private static void checkDocIDRuns(DocIdSetIterator iterator) throws IOException { + int prevDoc = -1; + int runEnd = 0; + for (int doc = iterator.nextDoc(); Review Comment: I wondered about it. We already have tests that test nextDoc vs. advance or nextDoc vs. intoBitSet. And "sane" impls of docIDRun should be free of side effects. So I thought that it would be enough this way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org