Re: [PR] Enable error-prone checks for NonFinalStaticField [lucene]

rmuir commented on PR #14228: URL: https://github.com/apache/lucene/pull/14228#issuecomment-2670465446 @msfroh if you get a chance, I think you just need to merge in `main` and it will take care of that CI issue. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] OptimisticKnnVectorQuery [lucene]

msokolov commented on code in PR #14226: URL: https://github.com/apache/lucene/pull/14226#discussion_r1962256467 ## lucene/core/src/java/org/apache/lucene/search/OptimisticKnnVectorQuery.java: ## @@ -0,0 +1,205 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] SortedSet DV Multi Range query [lucene]

mkhludnev commented on PR #13974: URL: https://github.com/apache/lucene/pull/13974#issuecomment-2669657925 It would be interesting to extend it to Numerics DVs and ranges aiming IP/masks -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[I] TestIndexWriterMergePolicy.testStressUpdateSameDocumentWithMergeOnCommit fails on nightly [lucene]

benwtrent opened a new issue, #14261: URL: https://github.com/apache/lucene/issues/14261 ### Description This fails with an OOM on nightly. I wonder if we are just merging too much :). I suspect this is due to the tiered merge policy change, but I might be wrong. haven't ran

Re: [PR] [Unit] Increase Dynamic Range Faceting coverage and address edge cases [lucene]

gsmiller merged PR #14258: URL: https://github.com/apache/lucene/pull/14258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

Re: [I] TestSsDvMultiRangeQuery.testDuelWithStandardDisjunction fails [lucene]

benwtrent commented on issue #14260: URL: https://github.com/apache/lucene/issues/14260#issuecomment-2669697888 Some additional seeds: > java.lang.AssertionError: expected:<1003+ hits> but was:<1001+ hits> ``` ./gradlew :lucene:sandbox:test --tests "org.apache.lucene.sandbox.sea

[I] TestSsDvMultiRangeQuery.testDuelWithStandardDisjunction fails [lucene]

benwtrent opened a new issue, #14260: URL: https://github.com/apache/lucene/issues/14260 ### Description ``` TestSsDvMultiRangeQuery > testDuelWithStandardDisjunction FAILED java.lang.AssertionError: expected:<1002+ hits> but was:<1001+ hits> at __randomizedtestin

Re: [PR] Accept nodes where score == Math.nextUp(results.minCompetitiveSimilarity()) after #14215 [lucene]

iverase merged PR #14249: URL: https://github.com/apache/lucene/pull/14249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [I] TestTieredMergePolicy.testPartialMerge fails [lucene]

jpountz closed issue #14255: TestTieredMergePolicy.testPartialMerge fails URL: https://github.com/apache/lucene/issues/14255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] TestTieredMergePolicy.testPartialMerge fails [lucene]

jpountz closed issue #14255: TestTieredMergePolicy.testPartialMerge fails URL: https://github.com/apache/lucene/issues/14255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Stop asserting on the max number of merged segments in TestTieredMergePolicy#testPartialMerge. [lucene]

jpountz merged PR #14259: URL: https://github.com/apache/lucene/pull/14259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Improve user-facing docs. [lucene]

jpountz merged PR #14251: URL: https://github.com/apache/lucene/pull/14251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[PR] Stop asserting on the max number of merged segments in TestTieredMergePolicy#testPartialMerge. [lucene]

jpountz opened a new pull request, #14259: URL: https://github.com/apache/lucene/pull/14259 This assertion isn't right as `TieredMergePolicy` has become more sophisticated with the introduction of `targetSearchConcurrency` and different merging rules for merges below the floor size.

Re: [PR] Move `CombinedFieldQuery` to the core module. [lucene]

jpountz commented on PR #14236: URL: https://github.com/apache/lucene/pull/14236#issuecomment-2667960241 Thanks for correcting the title @gsmiller. This doesn't look controversial to me and there haven't been objections, so I'm feeling free to merge. -- This is an automated message

Re: [PR] Move `CombinedFieldQuery` to the core module. [lucene]

jpountz merged PR #14236: URL: https://github.com/apache/lucene/pull/14236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] SortedSet DV Multi Range query [lucene]

gsmiller merged PR #13974: URL: https://github.com/apache/lucene/pull/13974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

Re: [PR] Move `CombinedFieldQuery` to the core module. [lucene]

gsmiller commented on PR #14236: URL: https://github.com/apache/lucene/pull/14236#issuecomment-2669347208 > Thanks for correcting the title @gsmiller. Ha, sorry couldn't help fixing the typo. I had this open to have a look then got busy with other stuff and never came back to it (want