Re: [PR] lucene-monitor: make abstract DocumentBatch public [lucene]

2024-11-26 Thread via GitHub
kotman12 commented on PR #13993: URL: https://github.com/apache/lucene/pull/13993#issuecomment-2502018488 Hey @romseygeek , this PR might not be the best forum but figure I'd mention this anyway.. I'm working on a [ReverseSearchQuery](https://github.com/kotman12/solr/pull/6/files) (name su

Re: [PR] Run filtered disjunctions with MaxScoreBulkScorer. [lucene]

2024-11-26 Thread via GitHub
jpountz commented on PR #14014: URL: https://github.com/apache/lucene/pull/14014#issuecomment-2501245938 ``` TaskQPS baseline StdDevQPS my_modified_version StdDevPct diff p-value FilteredOrStopWords 49.95 (3.

Re: [PR] Make WANDScorer compute scores on the fly. [lucene]

2024-11-26 Thread via GitHub
jpountz merged PR #14021: URL: https://github.com/apache/lucene/pull/14021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Add Query for reranking KnnFloatVectorQuery [lucene]

2024-11-26 Thread via GitHub
dungba88 commented on PR #14009: URL: https://github.com/apache/lucene/pull/14009#issuecomment-2502665806 I reran the benchmark, this time comparing the two-phase search against no-reranking as well. It seems the re-ranking phase only adds a trivial amount of latency so that's a good thing.

Re: [PR] Support multi-tenant RAM buffers for IndexWriter [lucene]

2024-11-26 Thread via GitHub
mdmarshmallow commented on code in PR #13951: URL: https://github.com/apache/lucene/pull/13951#discussion_r1859536180 ## lucene/core/src/java/org/apache/lucene/index/IndexWriterRAMManager.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Add Query for reranking KnnFloatVectorQuery with full-precision vectors [lucene]

2024-11-26 Thread via GitHub
dungba88 commented on code in PR #14009: URL: https://github.com/apache/lucene/pull/14009#discussion_r1859817240 ## lucene/core/src/java/org/apache/lucene/search/RerankKnnFloatVectorQuery.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Support multi-tenant RAM buffers for IndexWriter [lucene]

2024-11-26 Thread via GitHub
mdmarshmallow commented on code in PR #13951: URL: https://github.com/apache/lucene/pull/13951#discussion_r1859642908 ## lucene/core/src/java/org/apache/lucene/index/IndexWriterRAMManager.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Support multi-tenant RAM buffers for IndexWriter [lucene]

2024-11-26 Thread via GitHub
mdmarshmallow commented on code in PR #13951: URL: https://github.com/apache/lucene/pull/13951#discussion_r1859552804 ## lucene/core/src/java/org/apache/lucene/index/IndexWriterConfig.java: ## @@ -142,7 +142,21 @@ public IndexWriterConfig() { * problem you should switch to {

Re: [PR] Pruning of estimating the point value count in BooleanScorerSupplier [lucene]

2024-11-26 Thread via GitHub
github-actions[bot] commented on PR #13988: URL: https://github.com/apache/lucene/pull/13988#issuecomment-2502332479 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [I] Add refinement of quantized vector scores with fp distance calculations [lucene]

2024-11-26 Thread via GitHub
dungba88 commented on issue #13564: URL: https://github.com/apache/lucene/issues/13564#issuecomment-2499978963 I think there are still 2 issues to address: - Prevent quantized vectors from being swapped out: Loading full-precision vectors are costly and can cause the quantized vectors to