msokolov commented on PR #13872:
URL: https://github.com/apache/lucene/pull/13872#issuecomment-2462158029
hmm that commit is kind of messed up. Maybe I missed a rebase on main
somewhere? I will try to clean up here, but it might require a force-push or a
new PR, egad
--
This is an autom
gsmiller commented on code in PR #13886:
URL: https://github.com/apache/lucene/pull/13886#discussion_r1833153027
##
lucene/core/src/java/org/apache/lucene/search/IndexSortSortedNumericDocValuesRangeQuery.java:
##
@@ -397,106 +413,80 @@ private boolean matchAll(PointValues points
msokolov commented on PR #13872:
URL: https://github.com/apache/lucene/pull/13872#issuecomment-2462152791
Finally got back to this and fixed the aliasing that was happening. I ran
some perf tests and don't see significant variance. Still, it's clear we must
be doing a lot more allocations h
benwtrent commented on PR #13651:
URL: https://github.com/apache/lucene/pull/13651#issuecomment-2462723469
@ShashwatShivam why do you think the index size (total size of all the
files) should be smaller?
We store the binary quantized vectors and the floating point vectors. So, I
woul
iverase commented on code in PR #13886:
URL: https://github.com/apache/lucene/pull/13886#discussion_r1833247096
##
lucene/core/src/java/org/apache/lucene/search/IndexSortSortedNumericDocValuesRangeQuery.java:
##
@@ -397,106 +413,80 @@ private boolean matchAll(PointValues points,
msokolov commented on PR #13872:
URL: https://github.com/apache/lucene/pull/13872#issuecomment-2463077893
@ChrisHegarty I think it's expected since we would previously do the
allocation once per KnnVectorValues, but now we are doing it once per
RandomVectorScorer. I'm working on adding Clos
ShashwatShivam commented on PR #13651:
URL: https://github.com/apache/lucene/pull/13651#issuecomment-2463415182
@benwtrent makes sense, I wasn't accounting for the fact that the floating
vectors are being stored too. I guess I should have instead asked how to
reproduce the 'memory required'
iverase commented on code in PR #13886:
URL: https://github.com/apache/lucene/pull/13886#discussion_r1832348844
##
lucene/core/src/java/org/apache/lucene/search/IndexSortSortedNumericDocValuesRangeQuery.java:
##
@@ -397,106 +413,80 @@ private boolean matchAll(PointValues points,
cpoerschke commented on code in PR #13891:
URL: https://github.com/apache/lucene/pull/13891#discussion_r1832502452
##
lucene/CHANGES.txt:
##
@@ -47,6 +52,9 @@ API Changes
the entire segment should be scored. Subclasses that override the method
should instead override its rep
iverase commented on code in PR #13980:
URL: https://github.com/apache/lucene/pull/13980#discussion_r1832514220
##
lucene/core/src/java/org/apache/lucene/geo/Tessellator.java:
##
@@ -390,12 +377,108 @@ private static final void eliminateHole(
}
}
+ /** Choose a common
iverase commented on code in PR #13980:
URL: https://github.com/apache/lucene/pull/13980#discussion_r1832514627
##
lucene/core/src/test/org/apache/lucene/geo/TestTessellator.java:
##
@@ -928,12 +848,42 @@ public void testComplexPolygon55() throws Exception {
public void testC
iverase opened a new pull request, #13980:
URL: https://github.com/apache/lucene/pull/13980
One of the situation with David Eberly's algorithm for finding a bridge
between a hole and outer polygon was failing was the case of a polygon sharing
a vertex with the outer polygon. To fixed that
msokolov commented on PR #13872:
URL: https://github.com/apache/lucene/pull/13872#issuecomment-2462587122
## heap comparison
Here's the output from luceneutil's JFR heap usage summarizer. Clearly a
huge amount more allocations for this change.
### float32 mainline
```
PERCENT
ShashwatShivam commented on PR #13651:
URL: https://github.com/apache/lucene/pull/13651#issuecomment-2462601593
@benwtrent thanks for giving the link to the testing script, it works! One
question - the index size it reports is larger than the HNSW index size. For
e.g. I was working with a C
craigtaverner commented on code in PR #13980:
URL: https://github.com/apache/lucene/pull/13980#discussion_r1832435160
##
lucene/core/src/java/org/apache/lucene/geo/Tessellator.java:
##
@@ -390,12 +377,108 @@ private static final void eliminateHole(
}
}
+ /** Choose a
ChrisHegarty commented on PR #13872:
URL: https://github.com/apache/lucene/pull/13872#issuecomment-2462645675
thanks @msokolov I'll take another look at why the off-heap scorer is
allocating so much.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
iamsanjay commented on issue #13647:
URL: https://github.com/apache/lucene/issues/13647#issuecomment-2463893766
I was trying to set the
[luceneutil](https://github.com/mikemccand/luceneutil), ran the script.
```
python3 src/python/setup.py -download
```
It failed on one url where
vigyasharma commented on PR #13976:
URL: https://github.com/apache/lucene/pull/13976#issuecomment-2463936596
> any `IndexReader` should work as long as it can `openIfChanged` on itself.
Does `MultiReader` implement `openIfChanged()` ? I see a check in
`SearcherManager#refreshIfNeeded(
18 matches
Mail list logo
