cpoerschke commented on code in PR #13891: URL: https://github.com/apache/lucene/pull/13891#discussion_r1832502452
########## lucene/CHANGES.txt: ########## @@ -47,6 +52,9 @@ API Changes the entire segment should be scored. Subclasses that override the method should instead override its replacement. (Luca Cavanna) +* GITHUB#13757: For similarities, provide default computeNorm implementation and remove remaining discountOverlaps setters. + (Christine Poerschke, Adrien Grand, Robert Muir) Review Comment: Yes, https://lucene.apache.org/core/9_12_0/changes/Changes.html cannot be modified but my understanding is that the addition of the missing entry here would be included in https://lucene.apache.org/core/9_12_1/changes/Changes.html in future then, with the 9.12.1 file including 9.12.0 and earlier content also. Whether or not that's worthwhile, hmm, subjective I guess. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
