Re: [PR] [WIP] Multi-Vector support for HNSW search [lucene]

2024-10-26 Thread via GitHub
vigyasharma commented on PR #13525: URL: https://github.com/apache/lucene/pull/13525#issuecomment-2439876776 Thanks @benwtrent. I've been working on getting a multi-vector benchmark running to wire this end to end. Found some pesky bugs and oversights. I'm planning to split this feature int

Re: [PR] [SOLR-11191] SolrIndexSplitter: Init support for routing docs by _root_ when available [lucene-solr]

2024-10-26 Thread via GitHub
zkendall commented on PR #2686: URL: https://github.com/apache/lucene-solr/pull/2686#issuecomment-2439871664 Closing in favor of PR to solr repo: https://github.com/apache/solr/pull/2799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] [SOLR-11191] SolrIndexSplitter: Init support for routing docs by _root_ when available [lucene-solr]

2024-10-26 Thread via GitHub
zkendall closed pull request #2686: [SOLR-11191] SolrIndexSplitter: Init support for routing docs by _root_ when available URL: https://github.com/apache/lucene-solr/pull/2686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Use multi-select instead of a full sort for DynamicRange creation [lucene]

2024-10-26 Thread via GitHub
stefanvodita commented on code in PR #13914: URL: https://github.com/apache/lucene/pull/13914#discussion_r1817832373 ## lucene/facet/src/java/org/apache/lucene/facet/range/DynamicRangeUtil.java: ## @@ -202,66 +208,83 @@ public SegmentOutput(int hitsLength) { * is used to

Re: [PR] Use multi-select instead of a full sort for DynamicRange creation [lucene]

2024-10-26 Thread via GitHub
stefanvodita commented on code in PR #13914: URL: https://github.com/apache/lucene/pull/13914#discussion_r1817835241 ## lucene/core/src/java/org/apache/lucene/util/WeightedSelector.java: ## @@ -0,0 +1,407 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] Remove LeafSimScorer abstraction. [lucene]

2024-10-26 Thread via GitHub
jpountz merged PR #13957: URL: https://github.com/apache/lucene/pull/13957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [I] Absolutely horrible Lucene performance with JDK 23 (Lucene 9.11.1 and 10.0.0) [lucene]

2024-10-26 Thread via GitHub
jpountz commented on issue #13959: URL: https://github.com/apache/lucene/issues/13959#issuecomment-2439549339 Is there also no regression if you use the default garbage collector? If so, this looks like a regression with Shenandoah. -- This is an automated message from the Apache Git Serv

Re: [I] Absolutely horrible Lucene performance with JDK 23 (Lucene 9.11.1 and 10.0.0) [lucene]

2024-10-26 Thread via GitHub
derreisende77 commented on issue #13959: URL: https://github.com/apache/lucene/issues/13959#issuecomment-2439550280 I have no problem with default GC as well. I downloaded a Windows Amazon Corretto 23 nightly build from today and I don't have a problem with Shenandoah anymore. So I guess

Re: [I] Absolutely horrible Lucene performance with JDK 23 (Lucene 9.11.1 and 10.0.0) [lucene]

2024-10-26 Thread via GitHub
derreisende77 commented on issue #13959: URL: https://github.com/apache/lucene/issues/13959#issuecomment-2439422246 @benwtrent I made several tests on macOS with JDK 23 and 23.0.1 from Liberica and Azul. I always ran into the performance problem. I switched from Shenandoah GC to ZGC with

Re: [I] Absolutely horrible Lucene performance with JDK 23 (Lucene 9.11.1 and 10.0.0) [lucene]

2024-10-26 Thread via GitHub
derreisende77 closed issue #13959: Absolutely horrible Lucene performance with JDK 23 (Lucene 9.11.1 and 10.0.0) URL: https://github.com/apache/lucene/issues/13959 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a