Re: [I] Make dynamic range facets value collection and sorting faster [lucene]

2024-10-17 Thread via GitHub
timgrein commented on issue #13760: URL: https://github.com/apache/lucene/issues/13760#issuecomment-2418885695 > @timgrein , I've posted a PR for my idea that @stefanvodita mentioned. If you have the JMH benchmark, I'd love to test it out on mine as well. @HoustonPutman Sounds good, h

[PR] Use Arrays.mismatch in FSTCompiler#add. [lucene]

2024-10-17 Thread via GitHub
vsop-479 opened a new pull request, #13924: URL: https://github.com/apache/lucene/pull/13924 ### Description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] Improve Lucene's I/O concurrency [lucene]

2024-10-17 Thread via GitHub
jpountz commented on issue #13179: URL: https://github.com/apache/lucene/issues/13179#issuecomment-2418743923 There can always be follow-up improvements, but I think it's time to close this issue. Most usage of Lucene is now able to perform multiple concurrent I/O operations from the same s

Re: [I] Find more classes in main branch that can be converted to record classes [lucene]

2024-10-17 Thread via GitHub
jpountz closed issue #13207: Find more classes in main branch that can be converted to record classes URL: https://github.com/apache/lucene/issues/13207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] Find more classes in main branch that can be converted to record classes [lucene]

2024-10-17 Thread via GitHub
jpountz commented on issue #13207: URL: https://github.com/apache/lucene/issues/13207#issuecomment-2418745142 Lucene 10 is out, I'm closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[PR] Remove TODO in FSTCompiler#freezeTail. [lucene]

2024-10-17 Thread via GitHub
vsop-479 opened a new pull request, #13923: URL: https://github.com/apache/lucene/pull/13923 ### Description `node.numArcs == 0` happens on the last node(I think we fake it) of a input. But we set it `isFinal`, so we still can remove `node.numArcs == 0`. -- This is an automate

Re: [I] Added capability to auto force merge as much as possible to reduce the number of segments [lucene]

2024-10-17 Thread via GitHub
kkewwei closed issue #13925: Added capability to auto force merge as much as possible to reduce the number of segments URL: https://github.com/apache/lucene/issues/13925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Include java21 source folders to gradle source sets [lucene]

2024-10-17 Thread via GitHub
javanna commented on PR #13926: URL: https://github.com/apache/lucene/pull/13926#issuecomment-2419374325 This change does make these file visible as source files in IntelliJ, which is the issue I meant to address. I do need to sort out the build issues that come up though with my change (la

Re: [I] Performance difference between files getting opened with IOContext.RANDOM vs IOContext.READ during merges [lucene]

2024-10-17 Thread via GitHub
uschindler commented on issue #13920: URL: https://github.com/apache/lucene/issues/13920#issuecomment-2419196663 Thanks for opening the issue. I already made similar suggestion in another PR and also the mailing list. I'd go the route and temporarily change the IOContext to SEQUENTIAL

Re: [I] Performance difference between files getting opened with IOContext.RANDOM vs IOContext.READ during merges [lucene]

2024-10-17 Thread via GitHub
uschindler commented on issue #13920: URL: https://github.com/apache/lucene/issues/13920#issuecomment-2419198642 @jpountz ping. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Include java21 source folders to gradle source sets [lucene]

2024-10-17 Thread via GitHub
javanna commented on PR #13926: URL: https://github.com/apache/lucene/pull/13926#issuecomment-2419544522 Thanks @dweiss for chiming in, I clearly don't know what I am doing here :) > The main branch should be on Java 21 anyway so we could just move those files to src? Wait, bra

Re: [PR] Include java21 source folders to gradle source sets [lucene]

2024-10-17 Thread via GitHub
msokolov commented on PR #13926: URL: https://github.com/apache/lucene/pull/13926#issuecomment-2420520325 Thank you for addressing this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Try using Murmurhash 3 for bloom filters [lucene]

2024-10-17 Thread via GitHub
shubhamvishu commented on PR #12868: URL: https://github.com/apache/lucene/pull/12868#issuecomment-2420769033 I think yes we can make it final as it has no abstract methods so need to have it abstract. Git blame says it was made abstract >20 years ago by Doug so maybe it just stayed like th

Re: [I] Performance difference between files getting opened with IOContext.RANDOM vs IOContext.READ during merges [lucene]

2024-10-17 Thread via GitHub
shatejas commented on issue #13920: URL: https://github.com/apache/lucene/issues/13920#issuecomment-2421065908 @uschindler On a high level it makes sense to me. I have a couple of questions so that I understand this better > Add a method to Indexinput to change the IOContext (without

[PR] Change StringHelper from abstract to final. [lucene]

2024-10-17 Thread via GitHub
vsop-479 opened a new pull request, #13928: URL: https://github.com/apache/lucene/pull/13928 ### Description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Try using Murmurhash 3 for bloom filters [lucene]

2024-10-17 Thread via GitHub
vsop-479 commented on PR #12868: URL: https://github.com/apache/lucene/pull/12868#issuecomment-2421067764 Thanks @shubhamvishu , I opend https://github.com/apache/lucene/pull/13928. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] Avoid reload block when seeking backward in SegmentTermsEnum. [lucene]

2024-10-17 Thread via GitHub
vsop-479 commented on PR #13253: URL: https://github.com/apache/lucene/pull/13253#issuecomment-2421221398 Hello @mikemccand -- I am trying to simplify this change, it seems too complex. How about remove the reduce and restore entCount part? -- This is an automated message from the Apache

Re: [PR] Add BaseKnnVectorsFormatTestCase.testRecall() and fix old codecs [lucene]

2024-10-17 Thread via GitHub
msokolov merged PR #13910: URL: https://github.com/apache/lucene/pull/13910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

Re: [PR] Include java21 source folders to gradle source sets [lucene]

2024-10-17 Thread via GitHub
dweiss commented on PR #13926: URL: https://github.com/apache/lucene/pull/13926#issuecomment-2420026315 Yes, I think branch_10x is also on Java 21, minimum. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Add BaseKnnVectorsFormatTestCase.testRecall() and fix old codecs [lucene]

2024-10-17 Thread via GitHub
msokolov commented on PR #13910: URL: https://github.com/apache/lucene/pull/13910#issuecomment-2419873679 @benwtrent I think I addressed all your comments except adding binary vectors. I think as long as the vectors are not too degenerate and always the same the test purpose is satisfied, b

[PR] Fix StoredFieldsConsumer finish [lucene]

2024-10-17 Thread via GitHub
linfn opened a new pull request, #13927: URL: https://github.com/apache/lucene/pull/13927 ### Description The `lastDoc` will increment automatically within `startDocument` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub