msokolov commented on PR #13910: URL: https://github.com/apache/lucene/pull/13910#issuecomment-2419873679
@benwtrent I think I addressed all your comments except adding binary vectors. I think as long as the vectors are not too degenerate and always the same the test purpose is satisfied, but I'm not averse to replacing these janky ones with more "scientific" ones either, I just don't have the handy. This test seems to pass on multiple runs and it is exposing problems with the dictionary refactor I'm working on, so I think it's helpful -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
