javanna commented on code in PR #13737:
URL: https://github.com/apache/lucene/pull/13737#discussion_r1748020468
##
lucene/facet/src/java/org/apache/lucene/facet/FacetsCollectorManager.java:
##
@@ -54,4 +79,167 @@ public ReducedFacetsCollector(final
Collection facetsCollectors
javanna merged PR #13737:
URL: https://github.com/apache/lucene/pull/13737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
jpountz commented on code in PR #13697:
URL: https://github.com/apache/lucene/pull/13697#discussion_r1748062164
##
lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java:
##
@@ -156,6 +162,11 @@ public Scorer get(long leadCost) throws IOException {
stefanvodita commented on code in PR #13689:
URL: https://github.com/apache/lucene/pull/13689#discussion_r1748213889
##
lucene/demo/src/java/org/apache/lucene/demo/facet/DynamicRangeFacetsExample.java:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
stefanvodita commented on code in PR #13689:
URL: https://github.com/apache/lucene/pull/13689#discussion_r1748216227
##
lucene/facet/src/java/org/apache/lucene/facet/range/DynamicRangeUtil.java:
##
@@ -0,0 +1,276 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
rmuir commented on PR #13739:
URL: https://github.com/apache/lucene/pull/13739#issuecomment-2336480505
Lets update your migration PR with upgrade notes. Not many people want to
mess with automaton regex parser, so I see some value in keeping the commit
revertable? In general, trying to mini
zhaih opened a new pull request, #13741:
URL: https://github.com/apache/lucene/pull/13741
### Description
As discussed in #13715 this PR fixes:
1. `hashCode` of `CompiledAutomaton` forgot to consider `nfaRunAutomaton`
2. `ramBytesUsed` of `CompiledAutomaton` forgot to consider `
