dweiss merged PR #13728:
URL: https://github.com/apache/lucene/pull/13728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
aherbert commented on code in PR #13723:
URL: https://github.com/apache/lucene/pull/13723#discussion_r1746618586
##
lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCase.java:
##
@@ -881,27 +881,30 @@ public static void assumeNoException(String msg,
Excepti
cpoerschke opened a new pull request, #13731:
URL: https://github.com/apache/lucene/pull/13731
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
uschindler commented on PR #13728:
URL: https://github.com/apache/lucene/pull/13728#issuecomment-2333707595
Thanks. I wasn't aware of this extra File walk. Who added this? Thanks for
removing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
uschindler commented on code in PR #13723:
URL: https://github.com/apache/lucene/pull/13723#discussion_r1746885657
##
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyFacetAssociations.java:
##
@@ -654,7 +654,7 @@ private void assertFloatFacetResultsEqual(List
javanna commented on issue #13725:
URL: https://github.com/apache/lucene/issues/13725#issuecomment-2333752360
I agree @gsmiller , I am inclined to be stricter. Also, while we make this
breaking change, we can go directly from `Collector` to
`FacetsCollectorManager`. I am also considering mo
dweiss commented on issue #13719:
URL: https://github.com/apache/lucene/issues/13719#issuecomment-2333762856
> The check on a developers computer was not really wanted, so originally
the task was only executed on CI runs.
I don't know about that - I think it's one of the original reas
dweiss commented on PR #13728:
URL: https://github.com/apache/lucene/pull/13728#issuecomment-2333765565
> Thanks. I wasn't aware of this extra File walk. Who added this? Thanks for
removing it.
Can't remember. Could have been me. Clearly not working in all cases though.
--
This is
uschindler commented on PR #13572:
URL: https://github.com/apache/lucene/pull/13572#issuecomment-2333805272
Hi the whole setup of the calls to native code are not correct. In Lucene we
don't use or need "--enable-preview", because we have a special way to compile
the code ("you added it mar
ChrisHegarty opened a new pull request, #13732:
URL: https://github.com/apache/lucene/pull/13732
This commit adds a migration note about the removal of optional RegExp
complement support.
I just added a sentence to an existing section, but if we have further
advice it may be worth se
ChrisHegarty commented on PR #13732:
URL: https://github.com/apache/lucene/pull/13732#issuecomment-2333840754
The removal of the optional complement syntax is technically a "breaking"
change. It is of course fine to do such things in a major release, no issue
there. Just want to ensure that
javanna commented on code in PR #13733:
URL: https://github.com/apache/lucene/pull/13733#discussion_r1746991600
##
lucene/facet/src/java/org/apache/lucene/facet/FacetsCollectorManager.java:
##
@@ -54,4 +79,135 @@ public ReducedFacetsCollector(final
Collection facetsCollectors
mikemccand commented on PR #13732:
URL: https://github.com/apache/lucene/pull/13732#issuecomment-2333897038
Thanks @ChrisHegarty for catching this! It's important to document all
breaks in `MIGRATE.md`.
I'm trying to understand why/when we removed this operator. Was it really
durin
rmuir commented on PR #13732:
URL: https://github.com/apache/lucene/pull/13732#issuecomment-2333960253
maybe this small post with diagram helps explain the situation: I hope it is
more clear that there's no way we could support "let caller decide NFA vs DFA"
with this operator: https://euge
rmuir commented on PR #13732:
URL: https://github.com/apache/lucene/pull/13732#issuecomment-2333973731
and the title of this video can't be beat:
https://www.youtube.com/watch?v=bbMku8ZAoBk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
mikemccand commented on PR #13732:
URL: https://github.com/apache/lucene/pull/13732#issuecomment-2334106736
Phew, thank you for the historical context @rmuir!! I forgot about the
horrors of complementing NFAs... I love that talk title.
--
This is an automated message from the Apache Git
rmuir commented on PR #13732:
URL: https://github.com/apache/lucene/pull/13732#issuecomment-2334113812
Sorry, i was a bit offended that it might have been accidental :)
I tried to make it possible for us to support NFA query in straightforward
way, without bringing insanity to APIs, i
javanna commented on PR #13726:
URL: https://github.com/apache/lucene/pull/13726#issuecomment-2334115120
It seems like I missed something, maybe that's why these methods were not
migrated yet :) I got a failure with seed `8DDC50A89D6B6EC9`. Digging.
--
This is an automated message from th
gsmiller commented on code in PR #13733:
URL: https://github.com/apache/lucene/pull/13733#discussion_r1747170856
##
lucene/facet/src/java/org/apache/lucene/facet/FacetsCollectorManager.java:
##
@@ -54,4 +79,138 @@ public ReducedFacetsCollector(final
Collection facetsCollectors
msokolov commented on PR #13542:
URL: https://github.com/apache/lucene/pull/13542#issuecomment-2334328695
Adding a new optional constructor makes sense to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
gsmiller commented on PR #13735:
URL: https://github.com/apache/lucene/pull/13735#issuecomment-2334400226
OK, I _think_ this is still a safe implementation but the change is that
multiple collection threads will now be concurrently calling
`CandidateMatcher#addMatch`. I believe this is safe
gsmiller commented on issue #12892:
URL: https://github.com/apache/lucene/issues/12892#issuecomment-2334402205
Opened #13735 for the `monitor` usage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
gsmiller closed issue #13736: monitor: CollectingMatcher
URL: https://github.com/apache/lucene/issues/13736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
ChrisHegarty commented on PR #13732:
URL: https://github.com/apache/lucene/pull/13732#issuecomment-2334426390
Thank @rmuir. I included that advice in the migration note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
javanna commented on code in PR #13733:
URL: https://github.com/apache/lucene/pull/13733#discussion_r1747548475
##
lucene/facet/src/java/org/apache/lucene/facet/FacetsCollectorManager.java:
##
@@ -54,4 +79,138 @@ public ReducedFacetsCollector(final
Collection facetsCollectors
javanna commented on PR #13735:
URL: https://github.com/apache/lucene/pull/13735#issuecomment-2334629622
I am not familiar with this code but I believe you are correct. This should
work despite we use a plain `ArrayList`, because each thread should only get
and compute its own docs. Testing
Mikep86 commented on code in PR #13697:
URL: https://github.com/apache/lucene/pull/13697#discussion_r1747612996
##
lucene/join/src/test/org/apache/lucene/search/join/TestBlockJoinBulkScorer.java:
##
@@ -0,0 +1,450 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
javanna commented on PR #13733:
URL: https://github.com/apache/lucene/pull/13733#issuecomment-2334786138
Thanks a lot for the speedy review @gsmiller !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
javanna merged PR #13733:
URL: https://github.com/apache/lucene/pull/13733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
javanna closed issue #13725: Should the static search methods in
FacetsCollector take a FacetsCollector as last argument?
URL: https://github.com/apache/lucene/issues/13725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dweiss commented on issue #13719:
URL: https://github.com/apache/lucene/issues/13719#issuecomment-2334831855
About right. These are my top three:
```
git status
git add -A .
git commit -m "foo"
```
and these are used much, much more rarely:
```
git cherry-pick
git b
gsmiller commented on code in PR #13737:
URL: https://github.com/apache/lucene/pull/13737#discussion_r1747783583
##
lucene/facet/src/java/org/apache/lucene/facet/FacetsCollectorManager.java:
##
@@ -54,4 +79,167 @@ public ReducedFacetsCollector(final
Collection facetsCollectors
32 matches
Mail list logo
