gsmiller commented on PR #13735: URL: https://github.com/apache/lucene/pull/13735#issuecomment-2334400226
OK, I _think_ this is still a safe implementation but the change is that multiple collection threads will now be concurrently calling `CandidateMatcher#addMatch`. I believe this is safe but need another set of eyes on it. The reason I think this works is that we should never be interleaving calls with the same `doc` value since these are global docIDs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org