Re: [PR] Use Max WAND optimizations with ToParentBlockJoinQuery when using ScoreMode.Max [lucene]

2024-08-22 Thread via GitHub
jpountz commented on code in PR #13587: URL: https://github.com/apache/lucene/pull/13587#discussion_r1726465328 ## lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java: ## @@ -101,12 +101,18 @@ public Weight createWeight( .rewrite(new Con

[PR] Support JDK 23 in Panama Vectorization Provider [lucene]

2024-08-22 Thread via GitHub
ChrisHegarty opened a new pull request, #13678: URL: https://github.com/apache/lucene/pull/13678 This commit updates the Vectorization Provider to support JDK 23. The API has not changed so the changes minimally bump the major JDK check, and enable the incubating API during testing. -- T

Re: [PR] Take advantage of the doc value skipper when it is primary sort [lucene]

2024-08-22 Thread via GitHub
iverase commented on code in PR #13592: URL: https://github.com/apache/lucene/pull/13592#discussion_r1726673384 ## lucene/core/src/test/org/apache/lucene/search/TestDocValuesQueries.java: ## @@ -42,34 +45,100 @@ public class TestDocValuesQueries extends LuceneTestCase { +

Re: [PR] Take advantage of the doc value skipper when it is primary sort [lucene]

2024-08-22 Thread via GitHub
iverase commented on code in PR #13592: URL: https://github.com/apache/lucene/pull/13592#discussion_r1726674931 ## lucene/core/src/java/org/apache/lucene/index/DocValuesSkipper.java: ## @@ -98,4 +98,29 @@ public abstract class DocValuesSkipper { /** Return the global number

Re: [PR] Take advantage of the doc value skipper when it is primary sort [lucene]

2024-08-22 Thread via GitHub
iverase commented on code in PR #13592: URL: https://github.com/apache/lucene/pull/13592#discussion_r1726675935 ## lucene/core/src/java/org/apache/lucene/index/DocValuesSkipper.java: ## @@ -98,4 +98,29 @@ public abstract class DocValuesSkipper { /** Return the global number

Re: [PR] Modernize list get first element [lucene]

2024-08-22 Thread via GitHub
mrhbj closed pull request #13677: Modernize list get first element URL: https://github.com/apache/lucene/pull/13677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[PR] remove abandoned code [lucene]

2024-08-22 Thread via GitHub
mrhbj opened a new pull request, #13679: URL: https://github.com/apache/lucene/pull/13679 ### Description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] remove abandoned code [lucene]

2024-08-22 Thread via GitHub
mrhbj closed pull request #13679: remove abandoned code URL: https://github.com/apache/lucene/pull/13679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Take advantage of the doc value skipper when it is primary sort [lucene]

2024-08-22 Thread via GitHub
iverase merged PR #13592: URL: https://github.com/apache/lucene/pull/13592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Support JDK 23 in Panama Vectorization Provider [lucene]

2024-08-22 Thread via GitHub
ChrisHegarty merged PR #13678: URL: https://github.com/apache/lucene/pull/13678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

Re: [PR] Support JDK 23 in Panama Vectorization Provider [lucene]

2024-08-22 Thread via GitHub
uschindler commented on PR #13678: URL: https://github.com/apache/lucene/pull/13678#issuecomment-2304691487 Backport looks also fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[I] ComplexPhraseQueryParser parses wrongly when special characters found [lucene]

2024-08-22 Thread via GitHub
rajanvt-downstreem opened a new issue, #13680: URL: https://github.com/apache/lucene/issues/13680 ### Description \"media$kits weekend\"~10 get translated to "(media kits) weekend" with Slop:10 This cause the query to tag when a document has only media and weekend or kits and wee

Re: [PR] Use Max WAND optimizations with ToParentBlockJoinQuery when using ScoreMode.Max [lucene]

2024-08-22 Thread via GitHub
Mikep86 commented on code in PR #13587: URL: https://github.com/apache/lucene/pull/13587#discussion_r1727146876 ## lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java: ## @@ -101,12 +101,18 @@ public Weight createWeight( .rewrite(new Con

Re: [I] remove refs to people.apache.org/home.apache.org in build [lucene]

2024-08-22 Thread via GitHub
mikemccand commented on issue #13647: URL: https://github.com/apache/lucene/issues/13647#issuecomment-2304800950 Thanks @rmuir and @ChrisHegarty. I've downloaded all my content from `home.apache.org` (Lucene benchmark source corpora, line file docs, large vector file, etc.), so we won

Re: [PR] Use Max WAND optimizations with ToParentBlockJoinQuery when using ScoreMode.Max [lucene]

2024-08-22 Thread via GitHub
jpountz commented on code in PR #13587: URL: https://github.com/apache/lucene/pull/13587#discussion_r1727411649 ## lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java: ## @@ -101,12 +101,18 @@ public Weight createWeight( .rewrite(new Con

Re: [PR] Aggregate files from the same segment into a single Arena [lucene]

2024-08-22 Thread via GitHub
uschindler commented on PR #13570: URL: https://github.com/apache/lucene/pull/13570#issuecomment-2305145865 @ChrisHegarty the PR ist listed in the 9.x section of changes. I could work on a backport (possibly tomorrow). I just want to make sure you haven't started. I am not yet sure ho

Re: [I] remove refs to people.apache.org/home.apache.org in build [lucene]

2024-08-22 Thread via GitHub
mikemccand commented on issue #13647: URL: https://github.com/apache/lucene/issues/13647#issuecomment-2305153561 > I'm leaning towards a [simple GitHub pages site](https://docs.github.com/en/pages) (thank you @msokolov for the idea) I enabled pages for the `luceneutil` repro and pushe

Re: [I] Try applying bipartite graph reordering to KNN graph node ids [lucene]

2024-08-22 Thread via GitHub
jpountz commented on issue #13565: URL: https://github.com/apache/lucene/issues/13565#issuecomment-2305157956 > Does this choose a single bit-width for a group of postings? No, each posting can still have a different byte width, but it does the decoding in a way that doesn't have unpr

Re: [I] remove refs to people.apache.org/home.apache.org in build [lucene]

2024-08-22 Thread via GitHub
mikemccand commented on issue #13647: URL: https://github.com/apache/lucene/issues/13647#issuecomment-2305157923 A nice side effect of this is that the long running (13+ years now!) nightly reports will be backed up via git/GitHub and no longer single sourced on my home box, yay. And if ev

Re: [PR] Use Max WAND optimizations with ToParentBlockJoinQuery when using ScoreMode.Max [lucene]

2024-08-22 Thread via GitHub
Mikep86 commented on code in PR #13587: URL: https://github.com/apache/lucene/pull/13587#discussion_r1727552189 ## lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java: ## @@ -101,12 +101,18 @@ public Weight createWeight( .rewrite(new Con

Re: [PR] Override single byte writes to OutputStreamIndexOutput to remove locking [lucene]

2024-08-22 Thread via GitHub
msfroh commented on PR #13543: URL: https://github.com/apache/lucene/pull/13543#issuecomment-2305315023 > this change was merged: did you observe any change in the flame graphs? Yes! We were benchmarking on Lucene 9.11 and saw the time spent in `growIfNeeded` on JDK21 (and abo

Re: [PR] Aggregate files from the same segment into a single Arena [lucene]

2024-08-22 Thread via GitHub
ChrisHegarty commented on PR #13570: URL: https://github.com/apache/lucene/pull/13570#issuecomment-2305406563 > @ChrisHegarty the PR ist listed in the 9.x section of changes. I could work on a backport (possibly tomorrow). I just want to make sure you haven't started. > > I am not ye

Re: [I] remove refs to people.apache.org/home.apache.org in build [lucene]

2024-08-22 Thread via GitHub
msokolov commented on issue #13647: URL: https://github.com/apache/lucene/issues/13647#issuecomment-2305436221 Nice! glad it worked. FYI: I clicked on a few random links and found a 404 https://mikemccand.github.io/luceneutil/analyzers.html although this page does seem to exist on t

[PR] optimize code,change the 'return' position [lucene]

2024-08-22 Thread via GitHub
mrhbj opened a new pull request, #13681: URL: https://github.com/apache/lucene/pull/13681 ### Description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] optimize code,change the 'return' position [lucene]

2024-08-22 Thread via GitHub
mrhbj closed pull request #13681: optimize code,change the 'return' position URL: https://github.com/apache/lucene/pull/13681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To