Re: [PR] QueryRescorer: Use original order by default for same-score items rather than sorting by docId [lucene]

2024-06-24 Thread via GitHub
andywebb1975 commented on PR #13510: URL: https://github.com/apache/lucene/pull/13510#issuecomment-2186079766 I've been exploring constraining `maxValue` so we're more likely to see same-score items each time - e.g. using 50 in `int maxValue = TestUtil.nextInt(random(), 10, 50);` rather tha

Re: [PR] TaskExecutor should not fork unnecessarily [lucene]

2024-06-24 Thread via GitHub
javanna commented on PR #13472: URL: https://github.com/apache/lucene/pull/13472#issuecomment-2186218069 Thanks all for the feedback. It seems that we are converging on the improvement that this PR brings. I personally think that even besides performance, allowing to using a single executor

Re: [PR] TaskExecutor should not fork unnecessarily [lucene]

2024-06-24 Thread via GitHub
jpountz commented on PR #13472: URL: https://github.com/apache/lucene/pull/13472#issuecomment-2186238054 I think @mikemccand is in the process of giving more threads to nightly benchmarks. It would be good to collect a few data points before merging this change so that we can see a clear bu

Re: [PR] Use `IndexInput#prefetch` for terms dictionary lookups. [lucene]

2024-06-24 Thread via GitHub
jpountz commented on PR #13359: URL: https://github.com/apache/lucene/pull/13359#issuecomment-2186240846 I will merge soon if there are no objections. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go