Re: [PR] IndexWriter: Treat java.lang.Error as tragedy [lucene]

2024-04-06 Thread via GitHub
uschindler commented on PR #13277: URL: https://github.com/apache/lucene/pull/13277#issuecomment-2041021031 We should also check that we always rethrow `Error` and `RuntimeException` in those catch-all `catch (Throwable)` blocks. Otherwise they are silently converted to I would like

Re: [PR] IndexWriter: Treat java.lang.Error as tragedy [lucene]

2024-04-06 Thread via GitHub
rmuir commented on PR #13277: URL: https://github.com/apache/lucene/pull/13277#issuecomment-2041270352 > We should also check that we always rethrow `Error` and `RuntimeException` in those catch-all `catch (Throwable)` blocks. Otherwise they are silently converted to something different and