rmuir commented on PR #13277: URL: https://github.com/apache/lucene/pull/13277#issuecomment-2041270352
> We should also check that we always rethrow `Error` and `RuntimeException` in those catch-all `catch (Throwable)` blocks. Otherwise they are silently converted to something different and code here won't see this as tragedy. > > I would like to grep on `catch (Throwable` through all Lucene code and check that all is sane with rethrowing errors and runtimes unmodified. This is important especially with MethodHandles. This is unchanged from today though, if there are problems, they already affect us with `VirtualMachineError`. This just broadens the behavior check to `Error`. To be clear, I agree with the cleanup, but it should not be mixed inside this issue and needs to be broken up. There are a couple obvious cleanups in not-so-critical code here, but then there's important stuff, too (e.g. MMap is broke here, and definitely IndexWriter classes). Should not be mixed in this, it is just an unrelated cleanup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
