Re: [PR] hunspell GeneratingSuggester: ensure there are never more than 100 roots to process [lucene]

2024-03-05 Thread via GitHub
donnerpeter merged PR #13154: URL: https://github.com/apache/lucene/pull/13154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene

Re: [PR] hunspell: allow ignoring exceptions on duplicate ICONV/OCONV mappings [lucene]

2024-03-05 Thread via GitHub
donnerpeter merged PR #13155: URL: https://github.com/apache/lucene/pull/13155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene

[PR] Hunspell: don't proceed with other suggestions if we found good REP ones [lucene]

2024-03-05 Thread via GitHub
donnerpeter opened a new pull request, #13156: URL: https://github.com/apache/lucene/pull/13156 This makes "rep" and "ph" from TestHunspellRepositoryTestCases pass on latest revisions of the original Hunspell (after https://github.com/hunspell/hunspell/commit/b88f9ea57bdb9b219f3c1d2c67f4f88

Re: [PR] Hunspell: don't proceed with other suggestions if we found good REP ones [lucene]

2024-03-05 Thread via GitHub
donnerpeter merged PR #13156: URL: https://github.com/apache/lucene/pull/13156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene

Re: [PR] Add mult-leaf optimizations for diversify children collector [lucene]

2024-03-05 Thread via GitHub
benwtrent merged PR #13121: URL: https://github.com/apache/lucene/pull/13121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

[PR] Test case that exposes bug in PR #11724 [lucene]

2024-03-05 Thread via GitHub
mjustice3 opened a new pull request, #13157: URL: https://github.com/apache/lucene/pull/13157 ### Failing test case for TestHTMLStripCharFilter Test case mentioned in https://github.com/apache/lucene/pull/11724#issuecomment-1977531543 -- This is an automated message from the Apac

Re: [PR] Add new parallel merge task executor for parallel actions within a single merge action [lucene]

2024-03-05 Thread via GitHub
benwtrent commented on code in PR #13124: URL: https://github.com/apache/lucene/pull/13124#discussion_r1513208670 ## lucene/core/src/java/org/apache/lucene/index/ConcurrentMergeScheduler.java: ## @@ -910,4 +936,68 @@ public void setSuppressExceptions(ConcurrentMergeScheduler cm

Re: [PR] Add new parallel merge task executor for parallel actions within a single merge action [lucene]

2024-03-05 Thread via GitHub
msokolov commented on code in PR #13124: URL: https://github.com/apache/lucene/pull/13124#discussion_r1513268905 ## lucene/core/src/java/org/apache/lucene/index/ConcurrentMergeScheduler.java: ## @@ -910,4 +936,68 @@ public void setSuppressExceptions(ConcurrentMergeScheduler cms

Re: [PR] Add Facets#getBulkSpecificValues method [lucene]

2024-03-05 Thread via GitHub
gsmiller commented on code in PR #12862: URL: https://github.com/apache/lucene/pull/12862#discussion_r1513502215 ## lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java: ## @@ -568,6 +568,12 @@ public Number getSpecificValue(String dim, String... path) {

Re: [PR] Add Facets#getBulkSpecificValues method [lucene]

2024-03-05 Thread via GitHub
gsmiller commented on code in PR #12862: URL: https://github.com/apache/lucene/pull/12862#discussion_r1513504689 ## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyWriter.java: ## @@ -32,8 +32,8 @@ import org.apache.lucene.document.Field; impo

Re: [PR] Add Facets#getBulkSpecificValues method [lucene]

2024-03-05 Thread via GitHub
gsmiller commented on PR #12862: URL: https://github.com/apache/lucene/pull/12862#issuecomment-1979641229 @epotyom I saw Mike already approved. I did my own pass anyway so I understand the changes. They look good. Thanks! I left one small question for you about a default implementation. Let

Re: [PR] Writing a HOWTO migrate codec version [lucene]

2024-03-05 Thread via GitHub
github-actions[bot] commented on PR #12930: URL: https://github.com/apache/lucene/pull/12930#issuecomment-1979853435 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

[PR] Rename TestWildcard to TestWildcardQuery. [lucene]

2024-03-05 Thread via GitHub
vsop-479 opened a new pull request, #13159: URL: https://github.com/apache/lucene/pull/13159 Similar to `TestPrefixQuery` and `TestRegexpQuery`, it tests `WildcardQuery`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Change BP reordering logic to help support document blocks later on. [lucene]

2024-03-05 Thread via GitHub
rishabhmaurya commented on code in PR #13123: URL: https://github.com/apache/lucene/pull/13123#discussion_r1513889998 ## lucene/misc/src/java/org/apache/lucene/misc/index/BPIndexReorderer.java: ## @@ -341,116 +344,94 @@ protected void compute() { */ private boolean sh

Re: [PR] Terminate automaton after matched the whole prefix for PrefixQuery. [lucene]

2024-03-05 Thread via GitHub
vsop-479 commented on PR #13072: URL: https://github.com/apache/lucene/pull/13072#issuecomment-1980188859 > I think the optimization may be similar to the one done in AutomatonTermsEnum? It seems the optimization of `AutomatonTermsEnum` is to improve iterating term mode, from seeking