jimczi commented on code in PR #12962:
URL: https://github.com/apache/lucene/pull/12962#discussion_r1456027720
##
lucene/core/src/java/org/apache/lucene/index/LeafReader.java:
##
@@ -240,11 +241,19 @@ public final PostingsEnum postings(Term term) throws
IOException {
* @par
soren-xzk commented on code in PR #13017:
URL: https://github.com/apache/lucene/pull/13017#discussion_r1457089689
##
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:
##
@@ -5136,7 +5141,13 @@ private int mergeMiddle(MergePolicy.OneMerge merge,
MergePolicy mergePol
vsop-479 opened a new issue, #13022:
URL: https://github.com/apache/lucene/issues/13022
### Description
In TieredMergePolicy.doFindMerges, we pick up segments in segment size's
descending order, if `hitTooLarge` we need continue to find smaller segments.
If we pick up segments
s1monw opened a new pull request, #13023:
URL: https://github.com/apache/lucene/pull/13023
This change runs the current BWC indices generation code together with the
unittest to catch issues with the generated indices earliy. Each generation
method runs a sanity check on the generated indic
guojialiang92 commented on code in PR #13017:
URL: https://github.com/apache/lucene/pull/13017#discussion_r1457326578
##
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:
##
@@ -5136,7 +5141,13 @@ private int mergeMiddle(MergePolicy.OneMerge merge,
MergePolicy merg
guojialiang92 commented on issue #13015:
URL: https://github.com/apache/lucene/issues/13015#issuecomment-1898342410
> Whoa, what a doozie -- good find @guojialiang92! Concurrency is hard...
Thanks a lot, can you help me review the related PR?
--
This is an automated message from the
romseygeek commented on PR #12938:
URL: https://github.com/apache/lucene/pull/12938#issuecomment-1898672394
This seems reasonable - FunctionQuery doesn't actually match things, it just
scores, so it shouldn't be used for highlighting in any case.
Could you add a test to the highlighti
epotyom commented on code in PR #12966:
URL: https://github.com/apache/lucene/pull/12966#discussion_r1457584536
##
lucene/facet/src/java/org/apache/lucene/facet/sortedset/AbstractSortedSetDocValueFacetCounts.java:
##
@@ -347,8 +347,8 @@ private TopChildrenForPath computeTopChild
epotyom commented on code in PR #12951:
URL: https://github.com/apache/lucene/pull/12951#discussion_r1457735063
##
lucene/core/src/java/org/apache/lucene/util/fst/Util.java:
##
Review Comment:
I think `toUTF16` is another method in this class that can use `growNoCopy`.
But
epotyom commented on code in PR #12947:
URL: https://github.com/apache/lucene/pull/12947#discussion_r1457794657
##
lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/TaskSequence.java:
##
Review Comment:
Maybe I'm missing something, but isn't `countByTime` l
github-actions[bot] commented on PR #12930:
URL: https://github.com/apache/lucene/pull/12930#issuecomment-1899421572
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
github-actions[bot] commented on PR #12890:
URL: https://github.com/apache/lucene/pull/12890#issuecomment-1899421618
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
12 matches
Mail list logo
