javanna commented on PR #12718:
URL: https://github.com/apache/lucene/pull/12718#issuecomment-1780674911
thanks @s1monw for the review! I will add a changes entry and merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
tveasey commented on code in PR #12582:
URL: https://github.com/apache/lucene/pull/12582#discussion_r1372862574
##
lucene/core/src/java/org/apache/lucene/util/ScalarQuantizer.java:
##
@@ -0,0 +1,267 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
tveasey commented on code in PR #12582:
URL: https://github.com/apache/lucene/pull/12582#discussion_r1372862574
##
lucene/core/src/java/org/apache/lucene/util/ScalarQuantizer.java:
##
@@ -0,0 +1,267 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
luyuncheng opened a new pull request, #12723:
URL: https://github.com/apache/lucene/pull/12723
### Description
I see some hot_thread like following stack,
```
java.lang.Thread.State: RUNNABLE
at org.apache.lucene.store.DataInput.readVInt(DataInput.java:112)
javanna merged PR #12718:
URL: https://github.com/apache/lucene/pull/12718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
jmazanec15 commented on code in PR #12582:
URL: https://github.com/apache/lucene/pull/12582#discussion_r1373421235
##
lucene/core/src/java/org/apache/lucene/util/ScalarQuantizer.java:
##
@@ -0,0 +1,267 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
shubhamvishu commented on PR #12716:
URL: https://github.com/apache/lucene/pull/12716#issuecomment-1781810333
@mikemccand @bruno-roustant So I also ran the FST construction time
benchmarks on `wikimediumall` index using `IndexToFST` over a couple of
combinations of tweakable parameters to
Tony-X commented on code in PR #12688:
URL: https://github.com/apache/lucene/pull/12688#discussion_r1373799812
##
lucene/core/src/java/module-info.java:
##
@@ -35,6 +35,7 @@
exports org.apache.lucene.codecs.lucene95;
exports org.apache.lucene.codecs.lucene90.blocktree;
Tony-X commented on code in PR #12688:
URL: https://github.com/apache/lucene/pull/12688#discussion_r1373800366
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/radomaccess/TermsIndex.java:
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
stefanvodita commented on PR #12506:
URL: https://github.com/apache/lucene/pull/12506#issuecomment-1781893327
Thanks for the review @iverase! I’m putting together a new revision. Do you
have a name suggestion for `ByteSlicePool`? I don’t really have a better idea.
By putting it in a separat
uschindler commented on issue #12708:
URL: https://github.com/apache/lucene/issues/12708#issuecomment-1781948929
Hi, JDK-22 EA was updated to build 21, which contains fix for
https://bugs.openjdk.org/browse/JDK-8318646
--
This is an automated message from the Apache Git Service.
To respon
uschindler commented on issue #12708:
URL: https://github.com/apache/lucene/issues/12708#issuecomment-1781950343
I still think we should improve the test like als stated by openjdk people.
The exception mesage is not part of the sepc so you should not rely with tests
on its message. This ma
dungba88 commented on code in PR #12624:
URL: https://github.com/apache/lucene/pull/12624#discussion_r1373993909
##
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##
@@ -287,9 +315,9 @@ public long getMappedStateCount() {
return dedupHash == null ? 0 : no
gf2121 commented on code in PR #12723:
URL: https://github.com/apache/lucene/pull/12723#discussion_r1374099709
##
lucene/core/src/java/org/apache/lucene/util/DocBaseBitSetIterator.java:
##
@@ -69,6 +69,9 @@ public int getDocBase() {
@Override
public int nextDoc() {
+
gf2121 commented on code in PR #12723:
URL: https://github.com/apache/lucene/pull/12723#discussion_r1374099709
##
lucene/core/src/java/org/apache/lucene/util/DocBaseBitSetIterator.java:
##
@@ -69,6 +69,9 @@ public int getDocBase() {
@Override
public int nextDoc() {
+
luyuncheng commented on code in PR #12723:
URL: https://github.com/apache/lucene/pull/12723#discussion_r1374132105
##
lucene/core/src/java/org/apache/lucene/util/DocBaseBitSetIterator.java:
##
@@ -69,6 +69,9 @@ public int getDocBase() {
@Override
public int nextDoc() {
+
luyuncheng commented on code in PR #12723:
URL: https://github.com/apache/lucene/pull/12723#discussion_r1374132105
##
lucene/core/src/java/org/apache/lucene/util/DocBaseBitSetIterator.java:
##
@@ -69,6 +69,9 @@ public int getDocBase() {
@Override
public int nextDoc() {
+
17 matches
Mail list logo
