Re: [PR] Simplify TaskExecutor API [lucene]

2023-10-02 Thread via GitHub
javanna merged PR #12603: URL: https://github.com/apache/lucene/pull/12603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Reduce FST block size for BlockTreeTermsWriter [lucene]

2023-10-02 Thread via GitHub
gf2121 commented on PR #12604: URL: https://github.com/apache/lucene/pull/12604#issuecomment-1742668578 Hi @jpountz ! Would you please take a look at this PR when you have time? Looking forward to getting your suggestions on this topic ~ -- This is an automated message from the Apache Git

Re: [PR] Reduce FST block size for BlockTreeTermsWriter [lucene]

2023-10-02 Thread via GitHub
jpountz commented on PR #12604: URL: https://github.com/apache/lucene/pull/12604#issuecomment-1742678478 Oh, interesting find, it makes sense to me but I'm not the most familiar one with this piece of code. @mikemccand or @s1monw what do you think? -- This is an automated message from the

Re: [PR] Improve fallback sorter for BKD [lucene]

2023-10-02 Thread via GitHub
jpountz commented on code in PR #12610: URL: https://github.com/apache/lucene/pull/12610#discussion_r1342470366 ## lucene/core/src/java/org/apache/lucene/util/bkd/MutablePointTreeReaderUtils.java: ## @@ -81,6 +86,40 @@ protected int byteAt(int i, int k) { return (read

[PR] Override `normalize` method in the `PatternReplaceFilterFactory` [lucene]

2023-10-02 Thread via GitHub
dainiusjocas opened a new pull request, #12613: URL: https://github.com/apache/lucene/pull/12613 ### Description I've been debugging a problem with a classic query parser producing a `TermRangeQuery` with wrong tokens. I'm using a `CustomAnalyzer` that uses the `PatternReplaceFilter

Re: [I] Reproducible TestDrillSideways failure [lucene]

2023-10-02 Thread via GitHub
jpountz commented on issue #12418: URL: https://github.com/apache/lucene/issues/12418#issuecomment-1742740792 Sorry @Yuti-G I had missed your reply! I think that reverting the commit that you linked only made the test pass because this commit adds a call to `random().nextInt()` to `L

Re: [PR] Reduce FST block size for BlockTreeTermsWriter [lucene]

2023-10-02 Thread via GitHub
s1monw commented on PR #12604: URL: https://github.com/apache/lucene/pull/12604#issuecomment-1742998087 This change makes sense to me. @mikemccand WDYT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Concurrent hnsw graph and builder, take two [lucene]

2023-10-02 Thread via GitHub
jbellis closed pull request #12421: Concurrent hnsw graph and builder, take two URL: https://github.com/apache/lucene/pull/12421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Concurrent hnsw graph and builder, take two [lucene]

2023-10-02 Thread via GitHub
jbellis commented on PR #12421: URL: https://github.com/apache/lucene/pull/12421#issuecomment-1743159095 Thanks for the feedback. I've switched my efforts to a DiskANN implementation in JVector, so closing this out. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Add missing create github release step to release wizard [lucene]

2023-10-02 Thread via GitHub
javanna merged PR #12607: URL: https://github.com/apache/lucene/pull/12607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Create a task executor when executor is not provided [lucene]

2023-10-02 Thread via GitHub
reta commented on code in PR #12606: URL: https://github.com/apache/lucene/pull/12606#discussion_r1342999505 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -420,13 +418,12 @@ public int count(Query query) throws IOException { } /** - * Retur

Re: [PR] TaskExecutor waits for all tasks to complete before returning [lucene]

2023-10-02 Thread via GitHub
javanna commented on code in PR #12523: URL: https://github.com/apache/lucene/pull/12523#discussion_r1343009944 ## lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java: ## @@ -267,7 +266,133 @@ protected LeafSlice[] slices(List leaves) { return slic

Re: [PR] TaskExecutor waits for all tasks to complete before returning [lucene]

2023-10-02 Thread via GitHub
javanna commented on code in PR #12523: URL: https://github.com/apache/lucene/pull/12523#discussion_r1343038417 ## lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java: ## @@ -267,11 +266,130 @@ protected LeafSlice[] slices(List leaves) { return sli

Re: [PR] TaskExecutor waits for all tasks to complete before returning [lucene]

2023-10-02 Thread via GitHub
javanna commented on code in PR #12523: URL: https://github.com/apache/lucene/pull/12523#discussion_r1343042425 ## lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java: ## @@ -267,11 +266,130 @@ protected LeafSlice[] slices(List leaves) { return sli

Re: [PR] TaskExecutor waits for all tasks to complete before returning [lucene]

2023-10-02 Thread via GitHub
javanna commented on code in PR #12523: URL: https://github.com/apache/lucene/pull/12523#discussion_r1343048682 ## lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java: ## @@ -267,7 +266,133 @@ protected LeafSlice[] slices(List leaves) { return slic

Re: [PR] Add new int8 scalar quantization to HNSW codec [lucene]

2023-10-02 Thread via GitHub
benwtrent commented on code in PR #12582: URL: https://github.com/apache/lucene/pull/12582#discussion_r1343092520 ## lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java: ## @@ -139,7 +139,7 @@ public int nextDoc() throws IOException { } /** View over mult

Re: [PR] TaskExecutor waits for all tasks to complete before returning [lucene]

2023-10-02 Thread via GitHub
quux00 commented on code in PR #12523: URL: https://github.com/apache/lucene/pull/12523#discussion_r1343142475 ## lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java: ## @@ -267,11 +266,130 @@ protected LeafSlice[] slices(List leaves) { return slic

Re: [PR] TaskExecutor waits for all tasks to complete before returning [lucene]

2023-10-02 Thread via GitHub
quux00 commented on code in PR #12523: URL: https://github.com/apache/lucene/pull/12523#discussion_r1343180733 ## lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java: ## @@ -267,7 +266,133 @@ protected LeafSlice[] slices(List leaves) { return slice

Re: [PR] TaskExecutor waits for all tasks to complete before returning [lucene]

2023-10-02 Thread via GitHub
quux00 commented on code in PR #12523: URL: https://github.com/apache/lucene/pull/12523#discussion_r1343180948 ## lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java: ## @@ -267,7 +266,133 @@ protected LeafSlice[] slices(List leaves) { return slice

Re: [PR] TaskExecutor waits for all tasks to complete before returning [lucene]

2023-10-02 Thread via GitHub
quux00 commented on code in PR #12523: URL: https://github.com/apache/lucene/pull/12523#discussion_r1343185358 ## lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java: ## @@ -267,7 +266,133 @@ protected LeafSlice[] slices(List leaves) { return slice

Re: [PR] TaskExecutor waits for all tasks to complete before returning [lucene]

2023-10-02 Thread via GitHub
quux00 commented on code in PR #12523: URL: https://github.com/apache/lucene/pull/12523#discussion_r1343266881 ## lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java: ## @@ -267,11 +266,130 @@ protected LeafSlice[] slices(List leaves) { return slic

[PR] Make QueryCache respect Accountable queries on eviction and consisten… [lucene]

2023-10-02 Thread via GitHub
gtroitskiy opened a new pull request, #12614: URL: https://github.com/apache/lucene/pull/12614 …cy check **Root cause** `onQueryCache` increases `ramBytesUsed` for specified amount, that is being calculated with respect to query being `Accountable` or not. Unfortunately, `onQuer

Re: [PR] Run top-level conjunctions of term queries with a specialized BulkScorer. [lucene]

2023-10-02 Thread via GitHub
hossman commented on PR #12382: URL: https://github.com/apache/lucene/pull/12382#issuecomment-1744028622 git bisect has identified `f2bd0bbcdd38cd3c681a9d302bdb856f1a62208d` as the cause of a recent jenkins failure in `TestBlockMaxConjunction.testRandom` that reproduces reliably for me loca

Re: [PR] Run top-level conjunctions of term queries with a specialized BulkScorer. [lucene]

2023-10-02 Thread via GitHub
jpountz commented on PR #12382: URL: https://github.com/apache/lucene/pull/12382#issuecomment-1744317702 Thanks Hoss! I had missed this failure, it looks like a real one. I'm looking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to