[GitHub] [lucene] LuXugang commented on a diff in pull request #12405: Skip docs with Docvalues in NumericLeafComparator

2023-07-14 Thread via GitHub
LuXugang commented on code in PR #12405: URL: https://github.com/apache/lucene/pull/12405#discussion_r1263421231 ## lucene/core/src/java/org/apache/lucene/search/TopDocs.java: ## @@ -159,7 +159,12 @@ public MergeSortQueue(Sort sort, TopDocs[] shardHits, Comparator tieBr

[GitHub] [lucene] jpountz commented on issue #12439: Switch from MAXSCORE to BS1 with high numbers of clauses

2023-07-14 Thread via GitHub
jpountz commented on issue #12439: URL: https://github.com/apache/lucene/issues/12439#issuecomment-1635846764 Document frequencies have an impact indeed, but the logic would become quite complicated wouldn't it? Separately, by discussing about this with @jimczi, I realized that we may

[GitHub] [lucene] datbates commented on issue #12424: Add NO_COMPRESSION option to compression Mode

2023-07-14 Thread via GitHub
datbates commented on issue #12424: URL: https://github.com/apache/lucene/issues/12424#issuecomment-1636135349 That would work. Thanks for considering that. By the way we have increased our Lucene performance to better than its previous levels by introducing a full cache of our rec

[GitHub] [lucene] almogtavor commented on issue #12406: Register nested queries (ToParentBlockJoinQuery) to Lucene Monitor

2023-07-14 Thread via GitHub
almogtavor commented on issue #12406: URL: https://github.com/apache/lucene/issues/12406#issuecomment-1636198608 Can someone take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [lucene] gsmiller commented on pull request #12417: forutil add vectorized and scalar code

2023-07-14 Thread via GitHub
gsmiller commented on PR #12417: URL: https://github.com/apache/lucene/pull/12417#issuecomment-1636510014 Now for something possibly more useful. I brought the current vectorized version of ForUtil from this PR over to the local Lucene fork we use for Amazon product search and ran some inte

[GitHub] [lucene] tang-hi commented on pull request #12417: forutil add vectorized and scalar code

2023-07-14 Thread via GitHub
tang-hi commented on PR #12417: URL: https://github.com/apache/lucene/pull/12417#issuecomment-1636640909 It's great to see the performance results in a production environment. May I inquire if you employ the concept of lazy computation? If not, I believe it would be a big enhancement to in