ChrisHegarty commented on issue #12396:
URL: https://github.com/apache/lucene/issues/12396#issuecomment-1615848352
If I'm not mistaken, the specific interface required here to abstract out
`ForUtil` would look something like this?
```
interface ForUtilXXX {
/** Number of bytes req
uschindler commented on issue #12396:
URL: https://github.com/apache/lucene/issues/12396#issuecomment-1615851386
Hey, please for not let me do the integration. I have a plan already because
with the current version it wont work.
We have no secrets at moment, so the implementation can
uschindler commented on issue #12396:
URL: https://github.com/apache/lucene/issues/12396#issuecomment-1615852602
One we have some code here ready, I will submit a PR with the refactoring as
preparation.
--
This is an automated message from the Apache Git Service.
To respond to the message
stefanvodita opened a new pull request, #12409:
URL: https://github.com/apache/lucene/pull/12409
`SliceReader`, `SliceWriter`, and all other methods and fields having to do
with slices in `IntBlockPool` are moved to `MemoryIndex.SlicedIntBlockPool`, as
that is the only consumer of the slice
tang-hi commented on issue #12396:
URL: https://github.com/apache/lucene/issues/12396#issuecomment-1615878090
> One we have some code here ready, I will submit a PR with the refactoring
as preparation.
I've had some things to take care of in the past few days 😅, so I haven't
made muc
ChrisHegarty commented on issue #12396:
URL: https://github.com/apache/lucene/issues/12396#issuecomment-1615888789
@uschindler Ok, thanks. Sounds like you have this under control. And what
you say makes sense.
Did the small sketch of the ForUtil interface I provided above make sense?
uschindler commented on issue #12396:
URL: https://github.com/apache/lucene/issues/12396#issuecomment-1615890843
I like the idea to put everything under internal, we have that apckage
already.
But I would keep the implementations all under one package and let codes use
them (specific
ChrisHegarty commented on issue #12396:
URL: https://github.com/apache/lucene/issues/12396#issuecomment-1615897183
Thanks @uschindler, no great urgency on this part. As you have said earlier,
work on the actual vector implementation can proceed independently of the
general infrastructure -
ChrisHegarty commented on issue #12396:
URL: https://github.com/apache/lucene/issues/12396#issuecomment-1615898202
@tang-hi thanks for the update. I have some time later this weekend, I’ll
see if I can get this started, and take a look at your code.
--
This is an automated message from th
uschindler commented on issue #12396:
URL: https://github.com/apache/lucene/issues/12396#issuecomment-1615899286
I had some ideas in mind that the general lookup part just makes sure theres
is a paname impl available and then delegates to the panama provider to decide
which implementation t
10 matches
Mail list logo
