stefanvodita opened a new pull request, #12409: URL: https://github.com/apache/lucene/pull/12409
`SliceReader`, `SliceWriter`, and all other methods and fields having to do with slices in `IntBlockPool` are moved to `MemoryIndex.SlicedIntBlockPool`, as that is the only consumer of the slices functionality. There are a few other changes: 1. `IntBlockPool` is no longer `final`, which allows `SlicedIntBlockPool` to extend it. 2. I noticed a buffer pool test I had [committed previously](https://github.com/apache/lucene/pull/12392) was flawed and it only tested overflows for `ByteBlockPool`. I added the same test and corresponding fix for `IntBlockPool` and corrected the assertions. 3. All the existing `IntBlockPool` tests were testing slices. I moved those to their own test class and added a basic write/read/reset test in their place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
