uschindler commented on issue #12396:
URL: https://github.com/apache/lucene/issues/12396#issuecomment-1606834703
In my opinion, the best would be to proceed here without integrating in
Lucene and I can have a look at the code. The provider interfaces in Lucene are
still package private, so
javanna merged PR #12385:
URL: https://github.com/apache/lucene/pull/12385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
romseygeek merged PR #12388:
URL: https://github.com/apache/lucene/pull/12388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
stefanvodita commented on PR #12397:
URL: https://github.com/apache/lucene/pull/12397#issuecomment-1607296538
It looks like the automatic checker caught some more unused declared
exceptions. Not sure why I didn’t catch these when running `./gradlew check`.
I’ll investigate.
--
This is an
sohami commented on PR #12374:
URL: https://github.com/apache/lucene/pull/12374#issuecomment-1607787911
@jpountz Gentle reminder for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mkhludnev commented on PR #12397:
URL: https://github.com/apache/lucene/pull/12397#issuecomment-1607798359
Won't it change signature in an incompatible way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
stefanvodita commented on PR #12397:
URL: https://github.com/apache/lucene/pull/12397#issuecomment-1607837430
It would. I think there’s three categories of methods as far as this change
is concerned:
1. Methods the user can't override. We can safely change all of these.
2. Methods the
benwtrent commented on code in PR #12397:
URL: https://github.com/apache/lucene/pull/12397#discussion_r1242472556
##
lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/word2vec/Word2VecModel.java:
##
@@ -88,7 +87,7 @@ public int size() {
}
@Override
- pu
mayya-sharipova commented on issue #11507:
URL: https://github.com/apache/lucene/issues/11507#issuecomment-1607892454
I would like to renew the issue in light of the recent [integration of
incubating Panama Vector API](https://github.com/apache/lucene/pull/12311), as
indexing of vectors wit
javanna opened a new pull request, #12398:
URL: https://github.com/apache/lucene/pull/12398
Lucene has a non-public SliceExecutor abstraction that handles the execution
of tasks when search is executed concurrently across leaf slices. Knn query
vector rewrite has similar code that runs task
javanna commented on code in PR #12183:
URL: https://github.com/apache/lucene/pull/12183#discussion_r1242565055
##
lucene/core/src/java/org/apache/lucene/index/TermStates.java:
##
@@ -86,19 +92,58 @@ public TermStates(
* @param needsStats if {@code true} then all leaf contex
javanna commented on code in PR #12183:
URL: https://github.com/apache/lucene/pull/12183#discussion_r1242567436
##
lucene/core/src/java/org/apache/lucene/index/TermStates.java:
##
@@ -86,19 +92,58 @@ public TermStates(
* @param needsStats if {@code true} then all leaf contex
stefanvodita commented on PR #12397:
URL: https://github.com/apache/lucene/pull/12397#issuecomment-1608195952
Those are good points. What if we took a more targeted approach? Maybe we
can remove unused `throws` from the tests as a step in the right direction.
I’ve pushed a commit doing that
uschindler commented on PR #12397:
URL: https://github.com/apache/lucene/pull/12397#issuecomment-1608414484
In general I would like to keep all tests with "throws Expection". This
makes creating/modifying tests faster. I use a template whenever I create a new
test.
So please keep the
tflobbe merged PR #12360:
URL: https://github.com/apache/lucene/pull/12360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
zacharymorn commented on PR #12194:
URL: https://github.com/apache/lucene/pull/12194#issuecomment-1608695525
Thanks @jpountz for the feedback! On the second approach, I was actually
thinking something simpler, such as this
https://github.com/apache/lucene/pull/12194/commits/219beab1b1baea49
stefanvodita commented on PR #12397:
URL: https://github.com/apache/lucene/pull/12397#issuecomment-1608879221
Thanks for the feedback Uwe. I thought changing the tests would be
uncontroversial, but it sounds like you have a use-case for those exceptions.
I’ll close this PR.
--
This is an
stefanvodita closed pull request #12397: Remove redundant `throws` declarations
URL: https://github.com/apache/lucene/pull/12397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
18 matches
Mail list logo
