benwtrent commented on code in PR #12397:
URL: https://github.com/apache/lucene/pull/12397#discussion_r1242472556
##########
lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/word2vec/Word2VecModel.java:
##########
@@ -88,7 +87,7 @@ public int size() {
}
@Override
- public RandomAccessVectorValues<float[]> copy() throws IOException {
+ public RandomAccessVectorValues<float[]> copy() {
Review Comment:
This is an example of one you cannot remove. The class is `public` and not
final. So somebody could override the class and thus override this method.
` exports org.apache.lucene.analysis.synonym.word2vec;` also indicates its
exported in the public API for this Apache Lucene.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
