[GitHub] [lucene] alessandrobenedetti commented on pull request #12257: Add multi-thread searchability to OnHeapHnswGraph

alessandrobenedetti commented on PR #12257: URL: https://github.com/apache/lucene/pull/12257#issuecomment-1541925563 I still think this contribution to be valuable, as I don't like much the fact that OnHeapGraph is stateful. But I agree that the other contribution is solving a very simila

[GitHub] [lucene] alessandrobenedetti commented on pull request #12257: Add multi-thread searchability to OnHeapHnswGraph

alessandrobenedetti commented on PR #12257: URL: https://github.com/apache/lucene/pull/12257#issuecomment-1541938725 Another option, to be honest, is also to merge this first, and then the other committer will have to resolve the conflicts. This one is a very minimal change, so it doesn't

[GitHub] [lucene] jbellis opened a new pull request, #12281: Improve error checking in similarity functions, and use double precision internally

jbellis opened a new pull request, #12281: URL: https://github.com/apache/lucene/pull/12281 Cosine of two equal vectors is exactly 1, but we're losing too much precision on large-dimension vectors and ending up with NaN. (Presumably this does bad things for vectors that are not exactly equ

[GitHub] [lucene] mkhludnev merged pull request #12245: `ToParentBlockJoinQuery` Explain Support Score Mode

mkhludnev merged PR #12245: URL: https://github.com/apache/lucene/pull/12245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

[GitHub] [lucene] mkhludnev opened a new pull request, #12283: `ToParentBlockJoinQuery` Explain Support Score Mode (#12245)

mkhludnev opened a new pull request, #12283: URL: https://github.com/apache/lucene/pull/12283 `ToParentBlockJoinQuery` Explain Support Score Mode (#12245) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [lucene] mkhludnev commented on pull request #12283: `ToParentBlockJoinQuery` Explain Support Score Mode (#12245)

mkhludnev commented on PR #12283: URL: https://github.com/apache/lucene/pull/12283#issuecomment-1542489488 @MarcusSorealheis FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [lucene] mkhludnev merged pull request #12283: `ToParentBlockJoinQuery` Explain Support Score Mode (#12245)

mkhludnev merged PR #12283: URL: https://github.com/apache/lucene/pull/12283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

[GitHub] [lucene] veita opened a new issue, #12284: input automaton is too large: 1001 in Operations.topoSortStatesRecurse(Operations.java:1357)

veita opened a new issue, #12284: URL: https://github.com/apache/lucene/issues/12284 ### Description The error below appears many times per day and quickly fills the Solr logs up to gigabytes in size. Unfortunately I cannot tell what kind of input causes the error. However, th

[GitHub] [lucene] MarcusSorealheis commented on issue #12204: ToParentBlockJoinQuery's explain should depend on its ScoreMode

MarcusSorealheis commented on issue #12204: URL: https://github.com/apache/lucene/issues/12204#issuecomment-1542796091 @mkhludnev, @kashkambath, et. al this issue can be closed as the PR has been merged and backported to `9_x` -- This is an automated message from the Apache Git Service. T

[GitHub] [lucene] javanna opened a new pull request, #12285: Simplify SliceExecutor and QueueSizeBasedExecutor

javanna opened a new pull request, #12285: URL: https://github.com/apache/lucene/pull/12285 The only behaviour that QueueSizeBasedExecutor overrides from SliceExecutor is when to execute on the caller thread. There is no need to override the whole invokeAll method for that. Instead, this co

[GitHub] [lucene] tang-hi commented on issue #12284: input automaton is too large: 1001 in Operations.topoSortStatesRecurse(Operations.java:1357)

tang-hi commented on issue #12284: URL: https://github.com/apache/lucene/issues/12284#issuecomment-1543284928 It seems like the automaton has become too large and has exceeded the recursion limit. Perhaps we should consider changing topoSort to a non-recursive approach. I will work on fixin

[GitHub] [lucene] tang-hi opened a new pull request, #12286: toposort use iterator to avoid stackoverflow

tang-hi opened a new pull request, #12286: URL: https://github.com/apache/lucene/pull/12286 ### Description In Issue #12284, I observed that Lucene limits the recursion level in the `topoSortStatesRecurse` method to avoid a StackOverflow error during automaton topological sorting. I

[GitHub] [lucene] mkhludnev commented on issue #12204: ToParentBlockJoinQuery's explain should depend on its ScoreMode

mkhludnev commented on issue #12204: URL: https://github.com/apache/lucene/issues/12204#issuecomment-1543378416 should be at 9.7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [lucene] mkhludnev closed issue #12204: ToParentBlockJoinQuery's explain should depend on its ScoreMode

mkhludnev closed issue #12204: ToParentBlockJoinQuery's explain should depend on its ScoreMode URL: https://github.com/apache/lucene/issues/12204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the