[GitHub] [lucene] veqtor commented on pull request #874: LUCENE-10471 Increse max dims for vectors to 2048

2023-04-21 Thread via GitHub
veqtor commented on PR #874: URL: https://github.com/apache/lucene/pull/874#issuecomment-1517620551 > willing to take actions that go against science because vendors have told them it is right If, as you say, an entire document, regardless of it's lenght, content and so on, can be re

[GitHub] [lucene] mikemccand merged pull request #12232: [Documentation] Remove statement that SSDV facets aren't hierarchical

2023-04-21 Thread via GitHub
mikemccand merged PR #12232: URL: https://github.com/apache/lucene/pull/12232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[GitHub] [lucene] zhaih commented on a diff in pull request #12235: Optimize HNSW diversity calculation

2023-04-21 Thread via GitHub
zhaih commented on code in PR #12235: URL: https://github.com/apache/lucene/pull/12235#discussion_r1174215308 ## lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborArray.java: ## @@ -29,16 +29,27 @@ * @lucene.internal */ public class NeighborArray { + static final in

[GitHub] [lucene] zhaih commented on a diff in pull request #12235: Optimize HNSW diversity calculation

2023-04-21 Thread via GitHub
zhaih commented on code in PR #12235: URL: https://github.com/apache/lucene/pull/12235#discussion_r1174215397 ## lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborArray.java: ## @@ -62,7 +73,7 @@ public void add(int newNode, float newScore) { } /** Add a new node

[GitHub] [lucene] zhaih commented on a diff in pull request #12235: Optimize HNSW diversity calculation

2023-04-21 Thread via GitHub
zhaih commented on code in PR #12235: URL: https://github.com/apache/lucene/pull/12235#discussion_r1174215397 ## lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborArray.java: ## @@ -62,7 +73,7 @@ public void add(int newNode, float newScore) { } /** Add a new node

[GitHub] [lucene] zhaih commented on pull request #12235: Optimize HNSW diversity calculation

2023-04-21 Thread via GitHub
zhaih commented on PR #12235: URL: https://github.com/apache/lucene/pull/12235#issuecomment-1518409710 @msokolov Thanks for your feedback. Indeed the memory consumption is a concern and after I thought it more I found that it might be better to lazily sort the nodes and figure out which nod