[GitHub] [lucene] MarcusSorealheis commented on a diff in pull request #12208: Explain term automaton queries

2023-04-05 Thread via GitHub
MarcusSorealheis commented on code in PR #12208: URL: https://github.com/apache/lucene/pull/12208#discussion_r1158060254 ## lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestTermAutomatonQuery.java: ## @@ -842,6 +844,95 @@ public void testRewriteSimplePhrase() throws

[GitHub] [lucene] MarcusSorealheis commented on a diff in pull request #12208: Explain term automaton queries

2023-04-05 Thread via GitHub
MarcusSorealheis commented on code in PR #12208: URL: https://github.com/apache/lucene/pull/12208#discussion_r1158142144 ## lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestTermAutomatonQuery.java: ## @@ -842,6 +844,95 @@ public void testRewriteSimplePhrase() throws

[GitHub] [lucene] MarcusSorealheis commented on a diff in pull request #12208: Explain term automaton queries

2023-04-05 Thread via GitHub
MarcusSorealheis commented on code in PR #12208: URL: https://github.com/apache/lucene/pull/12208#discussion_r1158142961 ## lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestTermAutomatonQuery.java: ## @@ -842,6 +844,95 @@ public void testRewriteSimplePhrase() throws

[GitHub] [lucene] MarcusSorealheis commented on a diff in pull request #12208: Explain term automaton queries

2023-04-05 Thread via GitHub
MarcusSorealheis commented on code in PR #12208: URL: https://github.com/apache/lucene/pull/12208#discussion_r1158143400 ## lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestTermAutomatonQuery.java: ## @@ -842,6 +844,95 @@ public void testRewriteSimplePhrase() throws

[GitHub] [lucene] MarcusSorealheis commented on a diff in pull request #12208: Explain term automaton queries

2023-04-05 Thread via GitHub
MarcusSorealheis commented on code in PR #12208: URL: https://github.com/apache/lucene/pull/12208#discussion_r1158228357 ## lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestTermAutomatonQuery.java: ## @@ -842,6 +844,95 @@ public void testRewriteSimplePhrase() throws

[GitHub] [lucene] MarcusSorealheis commented on a diff in pull request #12208: Explain term automaton queries

2023-04-05 Thread via GitHub
MarcusSorealheis commented on code in PR #12208: URL: https://github.com/apache/lucene/pull/12208#discussion_r1158233897 ## lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestTermAutomatonQuery.java: ## @@ -842,6 +844,95 @@ public void testRewriteSimplePhrase() throws

[GitHub] [lucene] dantuzi commented on a diff in pull request #12169: Introduced the Word2VecSynonymFilter

2023-04-05 Thread via GitHub
dantuzi commented on code in PR #12169: URL: https://github.com/apache/lucene/pull/12169#discussion_r1158329797 ## lucene/test-framework/src/java/org/apache/lucene/tests/analysis/BaseTokenStreamTestCase.java: ## @@ -221,6 +223,12 @@ public static void assertTokenStreamContents(

[GitHub] [lucene] zhaih commented on a diff in pull request #12208: Explain term automaton queries

2023-04-05 Thread via GitHub
zhaih commented on code in PR #12208: URL: https://github.com/apache/lucene/pull/12208#discussion_r1158810796 ## lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestTermAutomatonQuery.java: ## @@ -842,6 +844,95 @@ public void testRewriteSimplePhrase() throws Exception {

[GitHub] [lucene] zhaih commented on a diff in pull request #12208: Explain term automaton queries

2023-04-05 Thread via GitHub
zhaih commented on code in PR #12208: URL: https://github.com/apache/lucene/pull/12208#discussion_r1158817727 ## lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestTermAutomatonQuery.java: ## @@ -842,6 +844,95 @@ public void testRewriteSimplePhrase() throws Exception {

[GitHub] [lucene] benwtrent opened a new issue, #12224: Find forever home for `KnnGraphTester`

2023-04-05 Thread via GitHub
benwtrent opened a new issue, #12224: URL: https://github.com/apache/lucene/issues/12224 ### Description `KnnGraphTester` is a good utility for creating a vector index, running searches, and then giving results. Consequently, it can be used for benchmarking and assessing recal

[GitHub] [lucene] MarcusSorealheis commented on a diff in pull request #12208: Explain term automaton queries

2023-04-05 Thread via GitHub
MarcusSorealheis commented on code in PR #12208: URL: https://github.com/apache/lucene/pull/12208#discussion_r1159010540 ## lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestTermAutomatonQuery.java: ## @@ -842,6 +844,95 @@ public void testRewriteSimplePhrase() throws

[GitHub] [lucene] MarcusSorealheis commented on pull request #12208: Explain term automaton queries

2023-04-05 Thread via GitHub
MarcusSorealheis commented on PR #12208: URL: https://github.com/apache/lucene/pull/12208#issuecomment-1498148310 > Sorry this is not what I meant. So first, the intend of the added unit test should test the explain code you added, but not rewriting nor explain implementation of TermQuery o

[GitHub] [lucene] MarcusSorealheis commented on a diff in pull request #12208: Explain term automaton queries

2023-04-05 Thread via GitHub
MarcusSorealheis commented on code in PR #12208: URL: https://github.com/apache/lucene/pull/12208#discussion_r1159037972 ## lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestTermAutomatonQuery.java: ## @@ -842,6 +843,91 @@ public void testRewriteSimplePhrase() throws

[GitHub] [lucene] Stupiddd opened a new issue, #12225: BulkOperationPacked decode() bug

2023-04-05 Thread via GitHub
Stupiddd opened a new issue, #12225: URL: https://github.com/apache/lucene/issues/12225 ### Description public void decode( byte[] blocks, int blocksOffset, long[] values, int valuesOffset, int iterations) { long nextValue = 0L; int bitsLeft = bitsPerValue;

[GitHub] [lucene] MarcusSorealheis commented on pull request #12208: Explain term automaton queries

2023-04-05 Thread via GitHub
MarcusSorealheis commented on PR #12208: URL: https://github.com/apache/lucene/pull/12208#issuecomment-1498479368 When I changed the tests to force `TermAutomatonQuery`, I noticed the scores changed. Thanks for that. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene] dnhatn commented on issue #12225: BulkOperationPacked decode() bug

2023-04-05 Thread via GitHub
dnhatn commented on issue #12225: URL: https://github.com/apache/lucene/issues/12225#issuecomment-1498523614 @Stupiddd It appears that this issue you are related to Lucene code. Could you please open an issue on the Lucene repository? Also, providing a more detailed description of the issue

[GitHub] [lucene] dnhatn closed issue #12225: BulkOperationPacked decode() bug

2023-04-05 Thread via GitHub
dnhatn closed issue #12225: BulkOperationPacked decode() bug URL: https://github.com/apache/lucene/issues/12225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [lucene] dnhatn commented on issue #12225: BulkOperationPacked decode() bug

2023-04-05 Thread via GitHub
dnhatn commented on issue #12225: URL: https://github.com/apache/lucene/issues/12225#issuecomment-1498525686 @Stupiddd My apologies, I mistakenly assumed that the issue was related to Elasticsearch repository. Can you please provide us with more details regarding the issue? This will assist

[GitHub] [lucene] zhaih commented on a diff in pull request #12208: Explain term automaton queries

2023-04-05 Thread via GitHub
zhaih commented on code in PR #12208: URL: https://github.com/apache/lucene/pull/12208#discussion_r1159361096 ## lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestTermAutomatonQuery.java: ## @@ -842,6 +844,95 @@ public void testRewriteSimplePhrase() throws Exception {

[GitHub] [lucene] zhaih commented on a diff in pull request #12208: Explain term automaton queries

2023-04-05 Thread via GitHub
zhaih commented on code in PR #12208: URL: https://github.com/apache/lucene/pull/12208#discussion_r1159363193 ## lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestTermAutomatonQuery.java: ## @@ -842,6 +843,92 @@ public void testRewriteSimplePhrase() throws Exception {

[GitHub] [lucene] zhaih commented on a diff in pull request #12208: Explain term automaton queries

2023-04-05 Thread via GitHub
zhaih commented on code in PR #12208: URL: https://github.com/apache/lucene/pull/12208#discussion_r1159363756 ## lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestTermAutomatonQuery.java: ## @@ -842,6 +843,91 @@ public void testRewriteSimplePhrase() throws Exception {