[GitHub] [lucene] rmuir commented on pull request #12191: Increase KnnByteVectorField limit on dimensions to 2048

2023-03-26 Thread via GitHub
rmuir commented on PR #12191: URL: https://github.com/apache/lucene/pull/12191#issuecomment-1484133375 > As for performance issues, this is why I am only suggesting the increase for byte encoded vectors as their size & performance improvements are just as reasonable at 2048 as float is at 1

[GitHub] [lucene] rmuir commented on pull request #12191: Increase KnnByteVectorField limit on dimensions to 2048

2023-03-26 Thread via GitHub
rmuir commented on PR #12191: URL: https://github.com/apache/lucene/pull/12191#issuecomment-1484135459 > @rmuir Ah, I thought your main concern was performance. I have multiple concerns: * HNSW doesn't scale at all (time, memory space) and there seems to be no plan to look into alt

[GitHub] [lucene] zacharymorn commented on a diff in pull request #12194: [GITHUB-11915] [Discussion Only] Make Lucene smarter about long runs of matches via new API on DISI

2023-03-26 Thread via GitHub
zacharymorn commented on code in PR #12194: URL: https://github.com/apache/lucene/pull/12194#discussion_r1148629792 ## lucene/core/src/java/org/apache/lucene/search/DocIdSetIterator.java: ## @@ -82,6 +82,11 @@ public int advance(int target) throws IOException { return d