[GitHub] [lucene] jpountz commented on a diff in pull request #12206: Fully reuse postings enums when flushing sorted indexes.

jpountz commented on code in PR #12206: URL: https://github.com/apache/lucene/pull/12206#discussion_r1137412879 ## lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataInput.java: ## @@ -71,7 +71,11 @@ public ByteBuffersDataInput(List buffers) { this.blockMask = (1

[GitHub] [lucene] mikemccand commented on a diff in pull request #12206: Fully reuse postings enums when flushing sorted indexes.

mikemccand commented on code in PR #12206: URL: https://github.com/apache/lucene/pull/12206#discussion_r1138515062 ## lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataInput.java: ## @@ -71,7 +71,11 @@ public ByteBuffersDataInput(List buffers) { this.blockMask =

[GitHub] [lucene] jpountz merged pull request #12206: Fully reuse postings enums when flushing sorted indexes.

jpountz merged PR #12206: URL: https://github.com/apache/lucene/pull/12206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] s1monw commented on a diff in pull request #12205: Remove remaining sources of contention on indexing.

s1monw commented on code in PR #12205: URL: https://github.com/apache/lucene/pull/12205#discussion_r1138779734 ## lucene/core/src/java/org/apache/lucene/index/DocumentsWriterFlushControl.java: ## @@ -604,7 +620,9 @@ long markForFullFlush() { * blocking indexing.*/

[GitHub] [lucene] jpountz commented on a diff in pull request #12205: Remove remaining sources of contention on indexing.

jpountz commented on code in PR #12205: URL: https://github.com/apache/lucene/pull/12205#discussion_r1138844621 ## lucene/core/src/java/org/apache/lucene/index/DocumentsWriterFlushControl.java: ## @@ -634,7 +652,9 @@ private void pruneBlockedQueue(final DocumentsWriterDeleteQue

[GitHub] [lucene] stefanvodita commented on pull request #11729: GITHUB#11728: Improve code clarity for OrdinalMap

stefanvodita commented on PR #11729: URL: https://github.com/apache/lucene/pull/11729#issuecomment-1472199332 Bumping this PR because I think it’s a good change in its current form. The increased expressiveness would be helpful to me if I was using this class. -- This is an automated mess

[GitHub] [lucene] magibney opened a new pull request, #12207: simplify PrefixQuery to avoid requiring Automaton

magibney opened a new pull request, #12207: URL: https://github.com/apache/lucene/pull/12207 For all but extremely selective queries (which are quite fast anyway), the performance of `PrefixQuery` benefits from directly subclassing `MultiTermQuery`, as opposed to subclassing `AutomatonQuery

[GitHub] [lucene] magibney commented on pull request #12207: simplify PrefixQuery to avoid requiring Automaton

magibney commented on PR #12207: URL: https://github.com/apache/lucene/pull/12207#issuecomment-1472396185 In evaluating this change with `luceneutil` benchmarks, I found that the change had _very_ different effects depending on how many terms were matched by a given prefix -- so I distingui

[GitHub] [lucene] jpountz commented on a diff in pull request #12205: Remove remaining sources of contention on indexing.

jpountz commented on code in PR #12205: URL: https://github.com/apache/lucene/pull/12205#discussion_r1139164751 ## lucene/core/src/java/org/apache/lucene/index/DocumentsWriterFlushControl.java: ## @@ -634,7 +652,9 @@ private void pruneBlockedQueue(final DocumentsWriterDeleteQue

[GitHub] [lucene] jpountz commented on a diff in pull request #12205: Remove remaining sources of contention on indexing.

jpountz commented on code in PR #12205: URL: https://github.com/apache/lucene/pull/12205#discussion_r1139165859 ## lucene/core/src/java/org/apache/lucene/index/DocumentsWriterFlushControl.java: ## @@ -133,7 +156,7 @@ private boolean assertMemory() { // peak document