mikemccand commented on code in PR #12206: URL: https://github.com/apache/lucene/pull/12206#discussion_r1138515062
########## lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataInput.java: ########## @@ -71,7 +71,11 @@ public ByteBuffersDataInput(List<ByteBuffer> buffers) { this.blockMask = (1 << blockBits) - 1; } - this.size = Arrays.stream(blocks).mapToLong(block -> block.remaining()).sum(); + long size = 0; + for (ByteBuffer block : blocks) { + size += block.remaining(); + } + this.size = size; Review Comment: This also helps greatly when looking at stack traces that traverse through stream'd code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org