[GitHub] [lucene] jpountz commented on a diff in pull request #12199: Reduce contention in DocumentsWriterPerThreadPool.

2023-03-13 Thread via GitHub
jpountz commented on code in PR #12199: URL: https://github.com/apache/lucene/pull/12199#discussion_r1133614094 ## lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThreadPool.java: ## @@ -130,13 +134,15 @@ private void ensureOpen() { } } + private synchr

[GitHub] [lucene] jpountz commented on a diff in pull request #12199: Reduce contention in DocumentsWriterPerThreadPool.

2023-03-13 Thread via GitHub
jpountz commented on code in PR #12199: URL: https://github.com/apache/lucene/pull/12199#discussion_r1133629633 ## lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThreadPool.java: ## @@ -113,15 +113,19 @@ private synchronized DocumentsWriterPerThread newWriter()

[GitHub] [lucene] dweiss commented on a diff in pull request #12199: Reduce contention in DocumentsWriterPerThreadPool.

2023-03-13 Thread via GitHub
dweiss commented on code in PR #12199: URL: https://github.com/apache/lucene/pull/12199#discussion_r1133644248 ## lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThreadPool.java: ## @@ -113,15 +113,19 @@ private synchronized DocumentsWriterPerThread newWriter() {

[GitHub] [lucene] uschindler commented on a diff in pull request #12199: Reduce contention in DocumentsWriterPerThreadPool.

2023-03-13 Thread via GitHub
uschindler commented on code in PR #12199: URL: https://github.com/apache/lucene/pull/12199#discussion_r1133699509 ## lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThreadPool.java: ## @@ -113,15 +113,19 @@ private synchronized DocumentsWriterPerThread newWriter(

[GitHub] [lucene] uschindler commented on a diff in pull request #12199: Reduce contention in DocumentsWriterPerThreadPool.

2023-03-13 Thread via GitHub
uschindler commented on code in PR #12199: URL: https://github.com/apache/lucene/pull/12199#discussion_r1133704928 ## lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThreadPool.java: ## @@ -113,15 +113,17 @@ private synchronized DocumentsWriterPerThread newWriter(

[GitHub] [lucene] uschindler commented on a diff in pull request #12199: Reduce contention in DocumentsWriterPerThreadPool.

2023-03-13 Thread via GitHub
uschindler commented on code in PR #12199: URL: https://github.com/apache/lucene/pull/12199#discussion_r1133708757 ## lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThreadPool.java: ## @@ -113,15 +113,17 @@ private synchronized DocumentsWriterPerThread newWriter(

[GitHub] [lucene] uschindler commented on a diff in pull request #12199: Reduce contention in DocumentsWriterPerThreadPool.

2023-03-13 Thread via GitHub
uschindler commented on code in PR #12199: URL: https://github.com/apache/lucene/pull/12199#discussion_r1133704928 ## lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThreadPool.java: ## @@ -113,15 +113,17 @@ private synchronized DocumentsWriterPerThread newWriter(

[GitHub] [lucene] uschindler commented on a diff in pull request #12199: Reduce contention in DocumentsWriterPerThreadPool.

2023-03-13 Thread via GitHub
uschindler commented on code in PR #12199: URL: https://github.com/apache/lucene/pull/12199#discussion_r1133708757 ## lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThreadPool.java: ## @@ -113,15 +113,17 @@ private synchronized DocumentsWriterPerThread newWriter(

[GitHub] [lucene] uschindler commented on a diff in pull request #12199: Reduce contention in DocumentsWriterPerThreadPool.

2023-03-13 Thread via GitHub
uschindler commented on code in PR #12199: URL: https://github.com/apache/lucene/pull/12199#discussion_r1133708757 ## lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThreadPool.java: ## @@ -113,15 +113,17 @@ private synchronized DocumentsWriterPerThread newWriter(

[GitHub] [lucene] dweiss commented on a diff in pull request #12199: Reduce contention in DocumentsWriterPerThreadPool.

2023-03-13 Thread via GitHub
dweiss commented on code in PR #12199: URL: https://github.com/apache/lucene/pull/12199#discussion_r1133753108 ## lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThreadPool.java: ## @@ -113,15 +113,17 @@ private synchronized DocumentsWriterPerThread newWriter() {

[GitHub] [lucene] jasirkt commented on issue #8966: Wildcard query parser of MultiFieldQueryParser should support boosts [LUCENE-7917]

2023-03-13 Thread via GitHub
jasirkt commented on issue #8966: URL: https://github.com/apache/lucene/issues/8966#issuecomment-1465981107 Apart from wildcard query, this issue also applies to fuzzy, prefix, range and regexp queries -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [lucene] uschindler commented on a diff in pull request #12199: Reduce contention in DocumentsWriterPerThreadPool.

2023-03-13 Thread via GitHub
uschindler commented on code in PR #12199: URL: https://github.com/apache/lucene/pull/12199#discussion_r1133798472 ## lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThreadPool.java: ## @@ -113,15 +113,17 @@ private synchronized DocumentsWriterPerThread newWriter(

[GitHub] [lucene] jasirkt opened a new pull request, #12202: Fix boost missing in MultiFieldQueryParser

2023-03-13 Thread via GitHub
jasirkt opened a new pull request, #12202: URL: https://github.com/apache/lucene/pull/12202 ### Description This fixes #8966. When using boost along with any of fuzzy, wildcard, regexp, range or prefix queries, the boost is not applied. -- This is an automated message from t

[GitHub] [lucene] rmuir merged pull request #12202: Fix boost missing in MultiFieldQueryParser

2023-03-13 Thread via GitHub
rmuir merged PR #12202: URL: https://github.com/apache/lucene/pull/12202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

[GitHub] [lucene] rmuir closed issue #8966: Wildcard query parser of MultiFieldQueryParser should support boosts [LUCENE-7917]

2023-03-13 Thread via GitHub
rmuir closed issue #8966: Wildcard query parser of MultiFieldQueryParser should support boosts [LUCENE-7917] URL: https://github.com/apache/lucene/issues/8966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene] rmuir commented on pull request #12202: Fix boost missing in MultiFieldQueryParser

2023-03-13 Thread via GitHub
rmuir commented on PR #12202: URL: https://github.com/apache/lucene/pull/12202#issuecomment-1466056963 @jasirkt thanks for fixing another boost bug in this parser! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [lucene] sherman opened a new issue, #12203: Scalable merge/compaction of big doc values segments.

2023-03-13 Thread via GitHub
sherman opened a new issue, #12203: URL: https://github.com/apache/lucene/issues/12203 ### Description The question is regarding the scalable merge/compaction of doc values, given the following context: I have a large sharded index. Each shard can contain segments of million

[GitHub] [lucene] kashkambath opened a new issue, #12204: ToParentBlockJoinQuery's explain should depend on its ScoreMode

2023-03-13 Thread via GitHub
kashkambath opened a new issue, #12204: URL: https://github.com/apache/lucene/issues/12204 ### Description Currently, `ToParentBlockJoinQuery`'s [explain()](https://github.com/apache/lucene/blob/4851bd74f402602f53719374b777c702a7d06fe5/lucene/join/src/java/org/apache/lucene/search/joi

[GitHub] [lucene] uschindler commented on pull request #12199: Reduce contention in DocumentsWriterPerThreadPool.

2023-03-13 Thread via GitHub
uschindler commented on PR #12199: URL: https://github.com/apache/lucene/pull/12199#issuecomment-1466877603 Thanks for the updates. Sorry for nitpicking, I just prefer code that goes sequentially and uses the pattern exit method as soon as condition mets. This makes it easier to understand.

[GitHub] [lucene] cknoxrun commented on issue #10608: FuzzyTermEnums sets negative boost for fuzzy search & highlight [LUCENE-9568]

2023-03-13 Thread via GitHub
cknoxrun commented on issue #10608: URL: https://github.com/apache/lucene/issues/10608#issuecomment-1466882597 You might already be thinking of this beyond apostrophes, but just in case I've recently come across this (with Elasticsearch) for characters other than apostrophes, specifically T

[GitHub] [lucene] mdmarshmallow commented on pull request #12194: [GITHUB-11915] [Discussion Only] Make Lucene smarter about long runs of matches via new API on DISI

2023-03-13 Thread via GitHub
mdmarshmallow commented on PR #12194: URL: https://github.com/apache/lucene/pull/12194#issuecomment-1466954686 Ok so I did some more investigation, I think there might be a bug with `Lucene90PostingsReader.BlockDocsEnum#peekNextNonMatchingDocID`. I haven't looked super deeply into it yet, b

[GitHub] [lucene] gsmiller commented on a diff in pull request #12184: [nocommit] Introduce ExpressionFacets along with a demo.

2023-03-13 Thread via GitHub
gsmiller commented on code in PR #12184: URL: https://github.com/apache/lucene/pull/12184#discussion_r1134695409 ## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/ExpressionFacets.java: ## @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [lucene] zacharymorn commented on pull request #12194: [GITHUB-11915] [Discussion Only] Make Lucene smarter about long runs of matches via new API on DISI

2023-03-13 Thread via GitHub
zacharymorn commented on PR #12194: URL: https://github.com/apache/lucene/pull/12194#issuecomment-1467191329 > Ok so I did some more investigation, I think there might be a bug with Lucene90PostingsReader.BlockDocsEnum#peekNextNonMatchingDocID. I haven't looked super deeply into it yet, but