uschindler commented on PR #12199: URL: https://github.com/apache/lucene/pull/12199#issuecomment-1466877603
Thanks for the updates. Sorry for nitpicking, I just prefer code that goes sequentially and uses the pattern exit method as soon as condition mets. This makes it easier to understand. Nice that there's no double locking anymore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
