[GitHub] [lucene] uschindler commented on a diff in pull request #12199: Reduce contention in DocumentsWriterPerThreadPool.

2023-03-12 Thread via GitHub
uschindler commented on code in PR #12199: URL: https://github.com/apache/lucene/pull/12199#discussion_r1133247211 ## lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThreadPool.java: ## @@ -130,13 +134,15 @@ private void ensureOpen() { } } + private syn

[GitHub] [lucene] zacharymorn commented on a diff in pull request #12194: [GITHUB-11915] [Discussion Only] Make Lucene smarter about long runs of matches via new API on DISI

2023-03-12 Thread via GitHub
zacharymorn commented on code in PR #12194: URL: https://github.com/apache/lucene/pull/12194#discussion_r1133315248 ## lucene/core/src/java/org/apache/lucene/search/DocIdSetIterator.java: ## @@ -211,4 +216,22 @@ protected final int slowAdvance(int target) throws IOException {

[GitHub] [lucene] zacharymorn commented on a diff in pull request #12194: [GITHUB-11915] [Discussion Only] Make Lucene smarter about long runs of matches via new API on DISI

2023-03-12 Thread via GitHub
zacharymorn commented on code in PR #12194: URL: https://github.com/apache/lucene/pull/12194#discussion_r1133315303 ## lucene/core/src/java/org/apache/lucene/search/ReqExclScorer.java: ## @@ -142,15 +142,43 @@ public TwoPhaseIterator twoPhaseIterator() { final float matchCo

[GitHub] [lucene] LuXugang commented on pull request #12153: Unrelated code in TestIndexSortSortedNumericDocValuesRangeQuery

2023-03-12 Thread via GitHub
LuXugang commented on PR #12153: URL: https://github.com/apache/lucene/pull/12153#issuecomment-1465417203 > it appears to have been carried over from some copy/paste of `TestDocValuesQueries#testToString` Thanks for the review @gsmiller -- This is an automated messag