[GitHub] [lucene] uschindler commented on pull request #12188: Alternative version: Implement MMapDirectory with Java 19/20 Project Panama Preview API

uschindler commented on PR #12188: URL: https://github.com/apache/lucene/pull/12188#issuecomment-1457731545 Hi FYI, here is the possible way to handle those licensing issues. A local patch that I have at hand may add a `panama-foreign-jdk20.txt` file next to the `panama-foreigen-jdk20.apija

[GitHub] [lucene] uschindler commented on pull request #12188: Alternative version: Implement MMapDirectory with Java 19/20 Project Panama Preview API

uschindler commented on PR #12188: URL: https://github.com/apache/lucene/pull/12188#issuecomment-1457739678 This is my local stashed patch (I used it to review the output): ```patch gradle/generation/panama-foreign.gradle| 6 - .../panama-foreign/ExtractForeignAPI.j

[GitHub] [lucene] uschindler commented on pull request #12188: Alternative version: Implement MMapDirectory with Java 19/20 Project Panama Preview API

uschindler commented on PR #12188: URL: https://github.com/apache/lucene/pull/12188#issuecomment-1457761017 I don't think this verbosity is needed, as the API is already available as Javadocs (there's no additional information that is not also available as Javadocs). FYI, the package privat

[GitHub] [lucene] uschindler commented on pull request #12188: Alternative version: Implement MMapDirectory with Java 19/20 Project Panama Preview API

uschindler commented on PR #12188: URL: https://github.com/apache/lucene/pull/12188#issuecomment-1457813085 I further minimized file sizes by removing contents of hidden classes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [lucene] dweiss commented on pull request #12188: Alternative version: Implement MMapDirectory with Java 19/20 Project Panama Preview API

dweiss commented on PR #12188: URL: https://github.com/apache/lucene/pull/12188#issuecomment-1457853933 I'm not a lawyer but I think a note in README next to those apijars is sufficient. There's no wrongdoing here and it's not a critical part of Lucene. I don't see how we could infringe any

[GitHub] [lucene] uschindler commented on pull request #12188: Alternative version: Implement MMapDirectory with Java 19/20 Project Panama Preview API

uschindler commented on PR #12188: URL: https://github.com/apache/lucene/pull/12188#issuecomment-1458208528 Hi @dweiss, I added a README.md: https://github.com/apache/lucene/blob/9cad5756461bf35cd56ce0d88a434884c89a16e8/lucene/core/src/generated/jdk/README.md -- This is an automated me

[GitHub] [lucene] jeffgan96 opened a new issue, #12193: FieldInfo#attributes should be exposed as variables instead of map

jeffgan96 opened a new issue, #12193: URL: https://github.com/apache/lucene/issues/12193 ### Description Currently, FieldInfo attributes map only stores PerFieldDocValuesFormat and PerFieldPostingsFormat. It is much costlier to read/write from this map multiple times as compared to i

[GitHub] [lucene] magibney commented on pull request #15: LUCENE-8972: Add ICUTransformCharFilter, to support pre-tokenizer ICU text transformation

magibney commented on PR #15: URL: https://github.com/apache/lucene/pull/15#issuecomment-1458406554 Belated thanks for the ping on this issue Mike, and thanks Robert for raising these concerns (and of course for your contributions to this PR already!). I'm sorry it has taken me so long to r

[GitHub] [lucene] gsmiller closed issue #11740: Can we improve cost estimation in TermInSetQuery's ScoreSupplier?

gsmiller closed issue #11740: Can we improve cost estimation in TermInSetQuery's ScoreSupplier? URL: https://github.com/apache/lucene/issues/11740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [lucene] gsmiller commented on issue #11740: Can we improve cost estimation in TermInSetQuery's ScoreSupplier?

gsmiller commented on issue #11740: URL: https://github.com/apache/lucene/issues/11740#issuecomment-1458502502 After experimenting with this some more, I haven't been able to come up with any sensible way of doing better cost estimation than we're already doing without actually doing some t

[GitHub] [lucene] mikemccand commented on a diff in pull request #12126: Refactor part of IndexFileDeleter and ReplicaFileDeleter into a common utility class

mikemccand commented on code in PR #12126: URL: https://github.com/apache/lucene/pull/12126#discussion_r1128355632 ## lucene/core/src/java/org/apache/lucene/index/IndexFileDeleter.java: ## @@ -154,7 +151,7 @@ public IndexFileDeleter( || fileName.startsWith(Index

[GitHub] [lucene] jpountz commented on issue #12193: FieldInfo#attributes should be exposed as variables instead of map

jpountz commented on issue #12193: URL: https://github.com/apache/lucene/issues/12193#issuecomment-1458829985 I have never seen a profile where this showed up. Can you tell a bit more about whether there are interesting things you are doing like flushing on every document or every couple ms

[GitHub] [lucene] mdmarshmallow commented on issue #11915: Make Lucene smarter about long runs of matches

mdmarshmallow commented on issue #11915: URL: https://github.com/apache/lucene/issues/11915#issuecomment-1459150300 If no one else is working on this issue, I would like to take a stab at it. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [lucene] zacharymorn opened a new pull request, #12194: [Discussion Only] Make Lucene smarter about long runs of matches via new API on DISI

zacharymorn opened a new pull request, #12194: URL: https://github.com/apache/lucene/pull/12194 *This PR is currently work in progress and is for discussion only* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene] zacharymorn commented on issue #11915: Make Lucene smarter about long runs of matches

zacharymorn commented on issue #11915: URL: https://github.com/apache/lucene/issues/11915#issuecomment-1459261207 Thanks @jpountz for the clarification! I was under a different assumption / understanding earlier actually, hence the additional questions. Your comment makes sense to me.

[GitHub] [lucene] zacharymorn commented on issue #11915: Make Lucene smarter about long runs of matches

zacharymorn commented on issue #11915: URL: https://github.com/apache/lucene/issues/11915#issuecomment-1459282541 Oh hi @mdmarshmallow , thanks for looking into this issue as well! I actually worked on it a bit in the last few days and just published a draft PR for it, but the PR is

[GitHub] [lucene] rmuir commented on a diff in pull request #12194: [GITHUB-11915] [Discussion Only] Make Lucene smarter about long runs of matches via new API on DISI

rmuir commented on code in PR #12194: URL: https://github.com/apache/lucene/pull/12194#discussion_r1128934912 ## lucene/core/src/java/org/apache/lucene/util/FixedBitSet.java: ## @@ -286,6 +286,33 @@ public int nextSetBit(int index) { return DocIdSetIterator.NO_MORE_DOCS;

[GitHub] [lucene] mdmarshmallow commented on issue #11915: Make Lucene smarter about long runs of matches

mdmarshmallow commented on issue #11915: URL: https://github.com/apache/lucene/issues/11915#issuecomment-1459502217 I actually wanted to work on this cause I think the `FixedBitSet#or` optimization could be nice for my use case. I can go ahead and maybe work on that section/add it to your d

[GitHub] [lucene] zhaih commented on a diff in pull request #12126: Refactor part of IndexFileDeleter and ReplicaFileDeleter into a common utility class

zhaih commented on code in PR #12126: URL: https://github.com/apache/lucene/pull/12126#discussion_r1129016525 ## lucene/CHANGES.txt: ## @@ -112,7 +112,8 @@ New Features Improvements - -(No changes) +* GITHUB#12126: Refactor part of IndexFileDeleter and Re

[GitHub] [lucene] jeffgan96 commented on issue #12193: FieldInfo#attributes should be exposed as variables instead of map

jeffgan96 commented on issue #12193: URL: https://github.com/apache/lucene/issues/12193#issuecomment-1459605863 not exactly. we have refresh interval set to 1 and high number of updates and indexing . index has >2 fields -- This is an automated message from the Apache Git Service. To

[GitHub] [lucene] zhaih commented on a diff in pull request #12126: Refactor part of IndexFileDeleter and ReplicaFileDeleter into a common utility class

zhaih commented on code in PR #12126: URL: https://github.com/apache/lucene/pull/12126#discussion_r1129023527 ## lucene/core/src/java/org/apache/lucene/index/IndexFileDeleter.java: ## @@ -154,7 +151,7 @@ public IndexFileDeleter( || fileName.startsWith(IndexFileN

[GitHub] [lucene] zhaih commented on a diff in pull request #12126: Refactor part of IndexFileDeleter and ReplicaFileDeleter into a common utility class

zhaih commented on code in PR #12126: URL: https://github.com/apache/lucene/pull/12126#discussion_r1129025441 ## lucene/core/src/java/org/apache/lucene/index/IndexFileDeleter.java: ## @@ -610,76 +601,34 @@ public void checkpoint(SegmentInfos segmentInfos, boolean isCommit) thro

[GitHub] [lucene] zhaih commented on a diff in pull request #12126: Refactor part of IndexFileDeleter and ReplicaFileDeleter into a common utility class

zhaih commented on code in PR #12126: URL: https://github.com/apache/lucene/pull/12126#discussion_r1129027852 ## lucene/core/src/java/org/apache/lucene/util/FileDeleter.java: ## @@ -0,0 +1,274 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont