zhaih commented on code in PR #12126:
URL: https://github.com/apache/lucene/pull/12126#discussion_r1129023527
##########
lucene/core/src/java/org/apache/lucene/index/IndexFileDeleter.java:
##########
@@ -154,7 +151,7 @@ public IndexFileDeleter(
|| fileName.startsWith(IndexFileNames.PENDING_SEGMENTS))) {
// Add this file to refCounts with initial count 0:
- getRefCount(fileName);
+ fileDeleter.getRefCount(fileName);
Review Comment:
Yeah I don't like that part, it's quite tricky, good thing is we're not
abusing the old `get` so I just followed your suggestion and created a
`initRefCount`, feels better now LOL.
##########
lucene/core/src/java/org/apache/lucene/index/IndexFileDeleter.java:
##########
@@ -154,7 +151,7 @@ public IndexFileDeleter(
|| fileName.startsWith(IndexFileNames.PENDING_SEGMENTS))) {
// Add this file to refCounts with initial count 0:
- getRefCount(fileName);
+ fileDeleter.getRefCount(fileName);
Review Comment:
Yeah I don't like that part either, it's quite tricky, good thing is we're
not abusing the old `get` so I just followed your suggestion and created a
`initRefCount`, feels better now LOL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
