zhaih merged PR #12160:
URL: https://github.com/apache/lucene/pull/12160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
rmuir commented on PR #12172:
URL: https://github.com/apache/lucene/pull/12172#issuecomment-1454694589
> For corectness' sake, I'd like to point out 2 things:
>
> * the s-cedilla counts probably also include the Turkish names present
in the Romanian Wikipedia, as well as file name
mkhludnev commented on PR #12160:
URL: https://github.com/apache/lucene/pull/12160#issuecomment-1454736416
May this failure relevant to this
https://jenkins.thetaphi.de/job/Lucene-9.x-Linux/8927/testReport/junit/org.apache.lucene.search/TestKnnFloatVectorQuery/testDocAndScoreQueryBasics/
kaivalnp commented on PR #12160:
URL: https://github.com/apache/lucene/pull/12160#issuecomment-1454759322
> May this failure relevant to this
https://jenkins.thetaphi.de/job/Lucene-9.x-Linux/8927/testReport/junit/org.apache.lucene.search/TestKnnFloatVectorQuery/testDocAndScoreQueryBasics/
shubhamvishu commented on code in PR #12183:
URL: https://github.com/apache/lucene/pull/12183#discussion_r1125496317
##
lucene/core/src/java/org/apache/lucene/search/BlendedTermQuery.java:
##
@@ -269,28 +273,55 @@ public String toString(String field) {
@Override
public fin
shubhamvishu commented on PR #12183:
URL: https://github.com/apache/lucene/pull/12183#issuecomment-1454792105
Thanks for the quick feedback @rmuir @uschindler !
> the change to BlendedTermQuery makes the code nearly unreadable. It is
important to be able to understand how it is litera
dsmiley commented on PR #11998:
URL: https://github.com/apache/lucene/pull/11998#issuecomment-1454862916
Love the change here to migrate away from per-segment-per-threadlocals!
When [porting this to Solr](https://github.com/apache/solr/pull/1360), I
noticed a new assertion that previo
rmuir commented on PR #11998:
URL: https://github.com/apache/lucene/pull/11998#issuecomment-1454871129
This was done on purpose as there's no such guarantee on `Terms` instances.
Of particular concern are the ones returned back from `TermVectors` class.
You can see above in the itera
