[GitHub] [lucene] tteofili commented on pull request #12169: Introduced the Word2VecSynonymFilter

tteofili commented on PR #12169: URL: https://github.com/apache/lucene/pull/12169#issuecomment-1446169959 will have a look in the next few days :bow: @alessandrobenedetti -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [lucene] jpountz commented on a diff in pull request #12055: Better skipping for multi-term queries with a FILTER rewrite.

jpountz commented on code in PR #12055: URL: https://github.com/apache/lucene/pull/12055#discussion_r1118982580 ## lucene/core/src/java/org/apache/lucene/search/DisiWrapper.java: ## @@ -57,4 +56,13 @@ public DisiWrapper(Scorer scorer) { matchCost = 0f; } } + + pu

[GitHub] [lucene] jpountz merged pull request #12113: Remove LogMergePolicy's boundary at the floor level.

jpountz merged PR #12113: URL: https://github.com/apache/lucene/pull/12113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] jpountz merged pull request #12170: Lazily resolve ordinals when merging.

jpountz merged PR #12170: URL: https://github.com/apache/lucene/pull/12170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] jpountz commented on a diff in pull request #12160: Concurrent rewrite for KnnVectorQuery

jpountz commented on code in PR #12160: URL: https://github.com/apache/lucene/pull/12160#discussion_r1119014642 ## lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java: ## @@ -73,17 +77,48 @@ public Query rewrite(IndexSearcher indexSearcher) throws IOExcept

[GitHub] [lucene] jpountz commented on pull request #12162: Add LatLonField class to index both LatLonPoint and LatLonDocValues

jpountz commented on PR #12162: URL: https://github.com/apache/lucene/pull/12162#issuecomment-1446752140 I agree we should have better ways to help users store these richer types, though ideally I'd like it to not fiddle with formatting, which feels like it may be a can of worms? Thinking o

[GitHub] [lucene] gsmiller commented on a diff in pull request #12158: Clone the BytesRef[] values in KeywordField#newSetQuery

gsmiller commented on code in PR #12158: URL: https://github.com/apache/lucene/pull/12158#discussion_r1119088046 ## lucene/core/src/java/org/apache/lucene/document/KeywordField.java: ## @@ -169,7 +169,7 @@ public static Query newSetQuery(String field, BytesRef... values) {

[GitHub] [lucene] jpountz commented on a diff in pull request #12162: Add LatLonField class to index both LatLonPoint and LatLonDocValues

jpountz commented on code in PR #12162: URL: https://github.com/apache/lucene/pull/12162#discussion_r1119110761 ## lucene/core/src/java/org/apache/lucene/document/LatLonField.java: ## @@ -0,0 +1,318 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [lucene] jpountz commented on a diff in pull request #12162: Add LatLonField class to index both LatLonPoint and LatLonDocValues

jpountz commented on code in PR #12162: URL: https://github.com/apache/lucene/pull/12162#discussion_r1119112950 ## lucene/core/src/java/org/apache/lucene/document/LatLonField.java: ## @@ -0,0 +1,318 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [lucene] kaivalnp commented on a diff in pull request #12160: Concurrent rewrite for KnnVectorQuery

kaivalnp commented on code in PR #12160: URL: https://github.com/apache/lucene/pull/12160#discussion_r1119176901 ## lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java: ## @@ -73,17 +77,48 @@ public Query rewrite(IndexSearcher indexSearcher) throws IOExcep

[GitHub] [lucene] kaivalnp commented on a diff in pull request #12160: Concurrent rewrite for KnnVectorQuery

kaivalnp commented on code in PR #12160: URL: https://github.com/apache/lucene/pull/12160#discussion_r1119178111 ## lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java: ## @@ -73,17 +77,48 @@ public Query rewrite(IndexSearcher indexSearcher) throws IOExcep

[GitHub] [lucene] kaivalnp commented on a diff in pull request #12160: Concurrent rewrite for KnnVectorQuery

kaivalnp commented on code in PR #12160: URL: https://github.com/apache/lucene/pull/12160#discussion_r1119180987 ## lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCase.java: ## @@ -210,7 +210,10 @@ public void testDimensionMismatch() throws IOException {

[GitHub] [lucene] gsmiller commented on a diff in pull request #12055: Better skipping for multi-term queries with a FILTER rewrite.

gsmiller commented on code in PR #12055: URL: https://github.com/apache/lucene/pull/12055#discussion_r1119197629 ## lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/CommonQueryParserConfiguration.java: ## @@ -55,12 +58,14 @@ public interface CommonQuer

[GitHub] [lucene] gsmiller commented on a diff in pull request #12055: Better skipping for multi-term queries with a FILTER rewrite.

gsmiller commented on code in PR #12055: URL: https://github.com/apache/lucene/pull/12055#discussion_r1119215684 ## lucene/CHANGES.txt: ## @@ -277,6 +277,9 @@ Improvements * GITHUB#12070: Compound file creation is no longer subject to merge throttling. (Adrien Grand) +* G

[GitHub] [lucene] gsmiller commented on a diff in pull request #12055: Better skipping for multi-term queries with a FILTER rewrite.

gsmiller commented on code in PR #12055: URL: https://github.com/apache/lucene/pull/12055#discussion_r1119345563 ## lucene/core/src/java/org/apache/lucene/search/DisiWrapper.java: ## @@ -57,4 +56,13 @@ public DisiWrapper(Scorer scorer) { matchCost = 0f; } } + + p

[GitHub] [lucene] gsmiller commented on pull request #12055: Better skipping for multi-term queries with a FILTER rewrite.

gsmiller commented on PR #12055: URL: https://github.com/apache/lucene/pull/12055#issuecomment-1447250930 > Apparently I can't approve since I opened the PR initially, but the change looks good to me! Ha! Thanks for having another look. This expanded a little in scope by keeping the

[GitHub] [lucene] gsmiller merged pull request #12055: Better skipping for multi-term queries with a FILTER rewrite.

gsmiller merged PR #12055: URL: https://github.com/apache/lucene/pull/12055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

[GitHub] [lucene] shubhamvishu opened a new pull request, #12171: Add APIs to get ordinal and category cache hit/miss count and hit rate in DirectoryTaxonomyReader

shubhamvishu opened a new pull request, #12171: URL: https://github.com/apache/lucene/pull/12171 ### Description Added apis in `DirectoryTaxonomyReader` to get the `ordinalCache` and `categoryCache` hit/miss count and also cache hit rate and a unit test `testCacheHitAndMissCount` to