[GitHub] [lucene] romseygeek commented on issue #10247: Don't build SpanQuery in QueryBuilder [LUCENE-9207]

2023-02-20 Thread via GitHub
romseygeek commented on issue #10247: URL: https://github.com/apache/lucene/issues/10247#issuecomment-1436600828 The scoring is sufficiently different with intervals that I don't think that's really viable. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [lucene] iverase opened a new issue, #12161: Add LatLonField class to index both LatLonPoint and LatLonDocValues

2023-02-20 Thread via GitHub
iverase opened a new issue, #12161: URL: https://github.com/apache/lucene/issues/12161 Similar to https://github.com/apache/lucene/issues/11199, it would be nice to have a class that can index both LatLonPoint and LatLonDocValues. -- This is an automated message from the Apache Git Servic

[GitHub] [lucene] iverase opened a new pull request, #12162: Add LatLonField class to index both LatLonPoint and LatLonDocValues

2023-02-20 Thread via GitHub
iverase opened a new pull request, #12162: URL: https://github.com/apache/lucene/pull/12162 Add new field that index both LatLonPoint and LatLonDocValues and provides factory methods for the operations that can be performed. Those are: ``` Query newGeometryQuery(String field, Shape

[GitHub] [lucene] ioanatia commented on issue #11829: Reproducible TestShapeDocValues failure

2023-02-20 Thread via GitHub
ioanatia commented on issue #11829: URL: https://github.com/apache/lucene/issues/11829#issuecomment-1436865949 @jpountz unless there have been more occurrences after https://github.com/apache/lucene/pull/12124 was merged, could this issue be closed? -- This is an automated message from t

[GitHub] [lucene] mkhludnev commented on issue #10247: Don't build SpanQuery in QueryBuilder [LUCENE-9207]

2023-02-20 Thread via GitHub
mkhludnev commented on issue #10247: URL: https://github.com/apache/lucene/issues/10247#issuecomment-1436936304 Thanks for answer, @romseygeek. Could you elaborate? Do you mean spans' scoring is equal to disjunction of phrases and intervals scoring can't be tweaked somehow closer to it? Ho

[GitHub] [lucene] rmuir commented on pull request #12162: Add LatLonField class to index both LatLonPoint and LatLonDocValues

2023-02-20 Thread via GitHub
rmuir commented on PR #12162: URL: https://github.com/apache/lucene/pull/12162#issuecomment-1437062026 Can we add newPolygonQuery and newBoxQuery just like LatLonPoint already has? To me, the newGeometryQuery method is unusable and overcomplicated. No user should struggle with how to

[GitHub] [lucene] rmuir commented on pull request #12162: Add LatLonField class to index both LatLonPoint and LatLonDocValues

2023-02-20 Thread via GitHub
rmuir commented on PR #12162: URL: https://github.com/apache/lucene/pull/12162#issuecomment-1437065088 I would also suggest removing the newGeometryQuery() method from what should be an easy-to-use field. The api is too insane... -- This is an automated message from the Apache Git Service

[GitHub] [lucene] rmuir commented on pull request #12162: Add LatLonField class to index both LatLonPoint and LatLonDocValues

2023-02-20 Thread via GitHub
rmuir commented on PR #12162: URL: https://github.com/apache/lucene/pull/12162#issuecomment-1437079826 in short: just the combination of methods from LatLonPoint + LatLonDocValuesField, minus the useless and overcomplicated geometry one, that provides no real benefits to point data:

[GitHub] [lucene] iverase commented on pull request #12162: Add LatLonField class to index both LatLonPoint and LatLonDocValues

2023-02-20 Thread via GitHub
iverase commented on PR #12162: URL: https://github.com/apache/lucene/pull/12162#issuecomment-1437092325 Sorry but I totally disagree, this is the most typical API for a geo application so if someone else struggle with it then it should not be developing a geo application. Anyway I don'

[GitHub] [lucene] rmuir commented on pull request #12162: Add LatLonField class to index both LatLonPoint and LatLonDocValues

2023-02-20 Thread via GitHub
rmuir commented on PR #12162: URL: https://github.com/apache/lucene/pull/12162#issuecomment-1437097724 LOL, dude who do you think wrote the point-in-polygon, distance, box stuff here? I guess i "should not be developing a geo application" What use-case does this crappy newGeometryQuer

[GitHub] [lucene] rmuir commented on pull request #12162: Add LatLonField class to index both LatLonPoint and LatLonDocValues

2023-02-20 Thread via GitHub
rmuir commented on PR #12162: URL: https://github.com/apache/lucene/pull/12162#issuecomment-1437100061 and yeah, to be clear i'm -1 against this change until we address this. I also have serious concerns about anyone who thinks this newGeometryQuery is "the most typical API". Stop, breathe,

[GitHub] [lucene] rmuir commented on pull request #12162: Add LatLonField class to index both LatLonPoint and LatLonDocValues

2023-02-20 Thread via GitHub
rmuir commented on PR #12162: URL: https://github.com/apache/lucene/pull/12162#issuecomment-1437105265 also btw, this API should not exist to support "people developing geo applications" anyway. I could give two shits about "geo nerds". These point method apis exist to support normal

[GitHub] [lucene] iverase commented on pull request #12162: Add LatLonField class to index both LatLonPoint and LatLonDocValues

2023-02-20 Thread via GitHub
iverase commented on PR #12162: URL: https://github.com/apache/lucene/pull/12162#issuecomment-1437106462 -1 for removing it so here we are. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [lucene] rmuir commented on pull request #12162: Add LatLonField class to index both LatLonPoint and LatLonDocValues

2023-02-20 Thread via GitHub
rmuir commented on PR #12162: URL: https://github.com/apache/lucene/pull/12162#issuecomment-1437106577 and don't forget, newGeometryQuery doesn't "do anything" you cant already do with the simple methods anyway for poinut data. It is 100% useless -- This is an automated message from the A

[GitHub] [lucene] rmuir commented on pull request #12162: Add LatLonField class to index both LatLonPoint and LatLonDocValues

2023-02-20 Thread via GitHub
rmuir commented on PR #12162: URL: https://github.com/apache/lucene/pull/12162#issuecomment-1437108733 -1 for removing a method that does nothing and has no value? :) Dude you have lost your mind! I recommend a psychiatrist! -- This is an automated message from the Apache Git Servi

[GitHub] [lucene] iverase commented on pull request #12162: Add LatLonField class to index both LatLonPoint and LatLonDocValues

2023-02-20 Thread via GitHub
iverase commented on PR #12162: URL: https://github.com/apache/lucene/pull/12162#issuecomment-1437192476 LOL it is impossible to disagree with you and not get insulted -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [lucene] benwtrent commented on a diff in pull request #12152: Minor vector search matching doc optimizations

2023-02-20 Thread via GitHub
benwtrent commented on code in PR #12152: URL: https://github.com/apache/lucene/pull/12152#discussion_r1112285170 ## lucene/core/src/test/org/apache/lucene/search/TestDocAndScoreQuery.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [lucene] dnhatn opened a new pull request, #12163: Ensure caching all leaves from the upper tier (#12147)

2023-02-20 Thread via GitHub
dnhatn opened a new pull request, #12163: URL: https://github.com/apache/lucene/pull/12163 Backport of #12147 to 9x This change adjusts the cache policy to ensure that all segments in the max tier to be cached. Before, we cache segments that have more than 3% of the total documents

[GitHub] [lucene] dnhatn opened a new pull request, #12164: Ensure caching all leaves from the upper tier (#12147)

2023-02-20 Thread via GitHub
dnhatn opened a new pull request, #12164: URL: https://github.com/apache/lucene/pull/12164 Backport of #12147 to 9_5 This change adjusts the cache policy to ensure that all segments in the max tier to be cached. Before, we cache segments that have more than 3% of the total documents

[GitHub] [lucene] dnhatn merged pull request #12163: Ensure caching all leaves from the upper tier (#12147)

2023-02-20 Thread via GitHub
dnhatn merged PR #12163: URL: https://github.com/apache/lucene/pull/12163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] dnhatn merged pull request #12164: Ensure caching all leaves from the upper tier (#12147)

2023-02-20 Thread via GitHub
dnhatn merged PR #12164: URL: https://github.com/apache/lucene/pull/12164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] MarcusSorealheis commented on pull request #12162: Add LatLonField class to index both LatLonPoint and LatLonDocValues

2023-02-20 Thread via GitHub
MarcusSorealheis commented on PR #12162: URL: https://github.com/apache/lucene/pull/12162#issuecomment-1437925210 I've been doing some research and hope MongoDB can help make an impact here soon for all of our customers. However, not speaking for MongoDB and only for myself, I want to weigh

[GitHub] [lucene] MarcusSorealheis commented on pull request #12162: Add LatLonField class to index both LatLonPoint and LatLonDocValues

2023-02-20 Thread via GitHub
MarcusSorealheis commented on PR #12162: URL: https://github.com/apache/lucene/pull/12162#issuecomment-1437977171 At this point, I don't know how a feature like Spatial knn could be implemented and it certainly would not rely on doc values for the approximation query, the existing and propo