[GitHub] [lucene] uschindler commented on pull request #12141: Avoid duplicate sorting in KeywordField#newSetQuery (alternative approach)

uschindler commented on PR #12141: URL: https://github.com/apache/lucene/pull/12141#issuecomment-142265 I am still not happy with this idea at all, because next to sorting we still build the PrefixCodedTerms instance 2 times on construction. I think the original idea of @gsmiller

[GitHub] [lucene] rmuir commented on issue #12140: LRUQueryCache disabled for indices with more than 33 segments

rmuir commented on issue #12140: URL: https://github.com/apache/lucene/issues/12140#issuecomment-1426700533 > I like medians better than averages in many cases, but would this require iterating over all segments in the index everytime we need to make a caching decision? I worry this could b

[GitHub] [lucene] rmuir commented on issue #12140: LRUQueryCache disabled for indices with more than 33 segments

rmuir commented on issue #12140: URL: https://github.com/apache/lucene/issues/12140#issuecomment-1426700879 > @rmuir Are you okay with Adrien's proposal? If so, I can start working on the fix. I don't really care so much, but let's please not overengineer it and just keep it simple.

[GitHub] [lucene] rmuir commented on pull request #12141: Avoid duplicate sorting in KeywordField#newSetQuery (alternative approach)

rmuir commented on PR #12141: URL: https://github.com/apache/lucene/pull/12141#issuecomment-1426703695 i want to see any proposed solution work for Points, too. Will hold these database features to the fire! -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [lucene] gsmiller commented on pull request #12141: Avoid duplicate sorting in KeywordField#newSetQuery (alternative approach)

gsmiller commented on PR #12141: URL: https://github.com/apache/lucene/pull/12141#issuecomment-1426788802 Thanks @uschindler for the alternate approach. It helped me understand your earlier suggestion to use streams, which I wasn't totally clear on (I thought you were originally suggesting

[GitHub] [lucene] gsmiller commented on pull request #12141: Avoid duplicate sorting in KeywordField#newSetQuery (alternative approach)

gsmiller commented on PR #12141: URL: https://github.com/apache/lucene/pull/12141#issuecomment-1426790254 +1 that it would be nice to avoid the duplicate prefix-encoding (and storing that duplicate data for two queries in memory). Ideally, it would be nice if `TermInSetQuery` where p

[GitHub] [lucene] ats1999 commented on issue #993: Raise a fake issue !Do not raise a real issue in GitHub until the official announcement is sent!

ats1999 commented on issue #993: URL: https://github.com/apache/lucene/issues/993#issuecomment-1426833247 Isn’t there any good first issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [lucene] ats1999 commented on issue #993: Raise a fake issue !Do not raise a real issue in GitHub until the official announcement is sent!

ats1999 commented on issue #993: URL: https://github.com/apache/lucene/issues/993#issuecomment-1426833303 Just checking! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [lucene] mocobeta commented on issue #993: Raise a fake issue !Do not raise a real issue in GitHub until the official announcement is sent!

mocobeta commented on issue #993: URL: https://github.com/apache/lucene/issues/993#issuecomment-1426938856 @ats1999 There's a label "good first issue" but it doesn't seem to be used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G