[GitHub] [lucene] jebnix commented on issue #11870: Create a Markdown based documentation

2023-01-05 Thread GitBox
jebnix commented on issue #11870: URL: https://github.com/apache/lucene/issues/11870#issuecomment-1372225809 @dweiss But currently, it's very hard and unintuitive to learn Lucene as a new user. In most libraries these days there is a docusaurus-like engine that generates a pretty nice and i

[GitHub] [lucene] benwtrent commented on pull request #12064: Create new KnnByteVectorField and KnnVectorsReader#getByteVectorValues(String)

2023-01-05 Thread GitBox
benwtrent commented on PR #12064: URL: https://github.com/apache/lucene/pull/12064#issuecomment-1372294789 Digging into it more, removing `AbstractVectorValues` will add a fair bit of extra code to the KnnVectorWriters and testing (though testing is a lesser concern I suppose). My t

[GitHub] [lucene] dweiss commented on issue #11870: Create a Markdown based documentation

2023-01-05 Thread GitBox
dweiss commented on issue #11870: URL: https://github.com/apache/lucene/issues/11870#issuecomment-1372325036 What I meant is that this documentation should really go into modules/ classes where it belongs and can be updated/ maintained together with the code. I honestly don't believe the ef

[GitHub] [lucene] jmazanec15 commented on issue #11354: Reuse HNSW graphs when merging segments? [LUCENE-10318]

2023-01-05 Thread GitBox
jmazanec15 commented on issue #11354: URL: https://github.com/apache/lucene/issues/11354#issuecomment-1372817284 @msokolov here are the results re-using a single index for each experiment. Overall, there is still some variability, it seems like there is less. For the 10K results, it appears

[GitHub] [lucene] jmazanec15 commented on a diff in pull request #12050: Reuse HNSW graph for intialization during merge

2023-01-05 Thread GitBox
jmazanec15 commented on code in PR #12050: URL: https://github.com/apache/lucene/pull/12050#discussion_r1062966074 ## lucene/core/src/java/org/apache/lucene/util/hnsw/OnHeapHnswGraph.java: ## @@ -94,36 +93,83 @@ public int size() { } /** - * Add node on the given level

[GitHub] [lucene] rmuir commented on issue #11870: Create a Markdown based documentation

2023-01-05 Thread GitBox
rmuir commented on issue #11870: URL: https://github.com/apache/lucene/issues/11870#issuecomment-1373144282 There is some markdown processed in this way for the release: https://lucene.apache.org/core/9_4_0/ Source code is here: https://github.com/apache/lucene/blob/main/lucene/docum

[GitHub] [lucene] rmuir commented on issue #11870: Create a Markdown based documentation

2023-01-05 Thread GitBox
rmuir commented on issue #11870: URL: https://github.com/apache/lucene/issues/11870#issuecomment-1373155758 The various overview.html's might even be the easiest ones to think about how markdown could work, rather than package summaries. These are currently maintained as html files, a